On Sat, Jan 13, 2007 at 08:27:16PM +0100, Juan RP wrote:
> 
> Hi,
> 
> The following patch adds support for the Power Management timer in the
> VIA VT86C686A and VIA VT8231 Southbridges plus hardware monitor
> support in the latter. This patch will sync the code with OpenBSD.
> 
> Could anyone with this hardware please report if that works?
[...]
> Please send full dmesg output and use "envstat -r" to see sensors
> output.

Thanks for doing this.

I just tested it on a HP Pavillion 7825, which has a VIA VT86C686A
chipset; and i can report that it works (dmesg attached).

In the mean time, i noted a few things:

1) dmesg output can be improved (by removing some extra newlines).

[...]
uhub1: 2 ports with 2 removable, self powered
viaenv0 at pci0 dev 7 function 4
: VIA VT82C686A Hardware Monitor
timecounter: Timecounter "viaenv0" frequency 3579545 Hz quality 1000
viaenv0 24-bit timer

auvia0 at pci0 dev 7 function 5: VIA Technologies VT82C686A AC'97 Audio (rev H)
[...]

2) For consistency with other device descriptions, we should better
   use `VIA Technologies' over `VIA' for vendor text.

njoly@cixy [~/NetBSD]> grep VIA dmesg.viaenv
pchb0: VIA Technologies VT8363 (Apollo KT133) Host Bridge (rev. 0x81)
ppb0 at pci0 dev 1 function 0: VIA Technologies VT8363 (Apollo KT133) PCI to AGP Bridge (rev. 0x00)
pcib0: VIA Technologies VT82C686A PCI-ISA Bridge (rev. 0x22)
viaide0: VIA Technologies VT82C686A (Apollo KX133) ATA66 controller
uhci0 at pci0 dev 7 function 2: VIA Technologies VT83C572 USB Controller (rev. 0x10)
uhub0: VIA Technologies UHCI root hub, class 9/0, rev 1.00/1.00, addr 1
uhci1 at pci0 dev 7 function 3: VIA Technologies VT83C572 USB Controller (rev. 0x10)
uhub1: VIA Technologies UHCI root hub, class 9/0, rev 1.00/1.00, addr 1
: VIA VT82C686A Hardware Monitor
auvia0 at pci0 dev 7 function 5: VIA Technologies VT82C686A AC'97 Audio (rev H)

3) The same timer does not show the same quality when attached from
   ACPI and viaenv.

timecounter: Timecounter "ACPI-Safe" frequency 3579545 Hz quality 900
ACPI-Safe 24-bit timer
[...]
timecounter: Timecounter "viaenv0" frequency 3579545 Hz quality 1000
viaenv0 24-bit timer

4) in `viaenv_attach()', the comment about enabling hardware monitor
   looks wrong, because the code to enable the HW is missing (but
   correct according to the vt82c686 datasheet).

-- 
Nicolas Joly

Biological Software and Databanks.
Institut Pasteur, Paris.