Subject: Re: mk.conf and build.sh
To: Patrick Welche <prlw1@newn.cam.ac.uk>
From: Luke Mewburn <lukem@NetBSD.org>
List: netbsd-help
Date: 07/14/2004 02:28:33
--DNUSDXU7R7AVVM8C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Jul 12, 2004 at 07:10:17PM +0100, Patrick Welche wrote:
| Revisiting MKOBJDIRS and build.sh, there is something wrong with
| the ordering. It is impossible to set MKOBJDIRS in mk.conf, and
| only possible to have it set (to "no") by passing the -o flag to
| build.sh. This may not have been the original intention given the
| following comment in build.sh:
|=20
| # Normalise MKOBJDIRS, MKUNPRIVED, and MKUPDATE
| # These may be set as build.sh options or in "mk.conf".
| # Don't export them as they're only used for tests in build.sh.
| # =20
| MKOBJDIRS=3D$(getmakevar MKOBJDIRS)
| MKUNPRIVED=3D$(getmakevar MKUNPRIVED)
| MKUPDATE=3D$(getmakevar MKUPDATE)
|=20
| The comment suggests they may be set in build.sh. Unfortunately,
| by the time this code (in validatemakeparams()) is called, MAKEFLAGS
| already contains MKOBJDIRS=3Dyes, as set in parseoptions(), so
| getmakevar, which calls make, which honours the environment variable
| MAKEFLAGS, will return the value of MKOBJDIRS overriden by MAKEFLAGS
| rather than the value it read from /etc/mk.conf (via
| bsd.prog.mk->bsd.init.mk->bsd.own.mk)
Please send-pr this issue.
--DNUSDXU7R7AVVM8C
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)
iD8DBQFA9A2xpBhtmn8zJHIRApWgAJ9ixn2i/zZ1Zr7s3jKGW1PMmcC4GwCfbS1c
xo4PZXpDwBNtuVimShGQKk0=
=MhWv
-----END PGP SIGNATURE-----
--DNUSDXU7R7AVVM8C--