> Except you'd be better off with quotes:
>                                 "ls -1 \"%s\" > %s",p,tmpname);
> 
> This will break if the filename pattern has quotes in it, but that's
> no worse than the original code.
> 
> Can you send-pr this?

FYI:

This type of issue is why i suggested the shquote() and shquotev()
functions recently on tech-kern.

Hopefully I'll get them wrapped up and into the source tree soon,
which should help with things like this going forward.

I wouldn't mind if other projects or software packages actually pick
up the interfaces (as long as they work the same 8-) or the
implementation...


chris
-- 
Chris Demetriou - cgd@netbsd.org - http://www.netbsd.org/People/Pages/cgd.html
Disclaimer: Not speaking for NetBSD, just expressing my own opinion.