NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/60621 (panic: ufs_inactive: dirty filesystem?)



On Tue, Nov 17, 2026 at 07:13:19PM +0000, Taylor R Campbell wrote:
> > Date: Tue, 17 Nov 2026 18:37:54 +0000
> > From: "J. Hannken-Illjes" <hannken%netbsd.org@localhost>
> > 
> > On Tue, Nov 17, 2026 at 06:11:53PM +0000, Taylor R Campbell wrote:
> > > > Date: Sun, 15 Nov 2026 14:32:10 +0000
> > > > From: "J. Hannken-Illjes" <hannken%netbsd.org@localhost>
> > [snip]
> > > > Using a persistent snapshot or no snapshot the "rm" succeeds.
> > > 
> > > I assume you mean `Using a *non*-persistent snapshot or no snapshot'?
> > 
> > I meant what I wrote: a persistent snapshot.  As long as the snapshot
> > is not unlinked it will sync its data bypassing wapbl as the snapshot
> > activates BEFORE wapbl on mount.
> 
> Oh, I see -- you meant a file-system-internal snapshot that has _not_
> been unlinked (as in, e.g., `fssconfig fss0 / /mysnap'), as opposed to
> an fs-internal snapshot that _has_ been unlinked (as in, e.g.,
> `fssconfig -x fss0 / /mysnap' or simply `fssconfig fss0 / /', which
> triggers the crash).  Is that right?

Yes.

[snip]
> So if I understand correctly, the reproducer:
> 
> - crashes with internal unlinked snapshot
> - works with internal still-linked (`persistent') snapshot
> - works with no snapshot
> - presumably works with external snapshot, whether linked or unlinked

Yes.

> This suggests a (purely speculative, unconfirmed) hypothesis about the
> `ufs_inactive: dirty filesystem?' panic, that the fast path of writing
> to unlinked internal snapshots doesn't work with wapbl because it
> allocates blocks and updates i_blocks without grouping them into a
> single atomic transaction.

I suppose it is ffs_snapblkfree() claiming the freed block.  The
block moves to the snapshot and its i_blocks increases.  Don't know
how to group the snapshot inode update into this transaction yet.

-- 
J. Hannken-Illjes - hannken%netbsd.org@localhost



Home | Main Index | Thread Index | Old Index