NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
PR/60851 CVS commit: src
The following reply was made to PR kern/60851; it has been noted by GNATS.
From: "Taylor R Campbell" <riastradh%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc:
Subject: PR/60851 CVS commit: src
Date: Mon, 5 Oct 2026 20:49:13 +0000
Module Name: src
Committed By: riastradh
Date: Mon Oct 5 20:49:13 UTC 2026
Modified Files:
src/sys/kern: sys_pipe.c
src/tests/kernel/kqueue/read: t_pipe.c
src/tests/kernel/kqueue/write: t_pipe.c
Log Message:
pipe(2): Restore kevent EVFILT_READ/WRITE success on wrong pipe end.
In rev. 1.174, while cleaning up various issues in select/poll/kqueue
logic for pipes, I changed the behaviour of kevent when adding an
EVFILT_READ event for the write side of a pipe, or an EVFILT_WRITE
event for the read side of a pipe, to fail with EINVAL; previously it
would quietly be accepted and do nothing, which struck me, without much
thought, as uncontroversially wrong and unhelpful. But apparently
that's what FreeBSD and OpenBSD do too, and it seems that applications
such as mail/dovecot2 rely on it. So put it back.
PR kern/60851: change in pipe kevent EVFILT_READ/WRITE on wrong end
To generate a diff of this commit:
cvs rdiff -u -r1.179 -r1.180 src/sys/kern/sys_pipe.c
cvs rdiff -u -r1.3 -r1.4 src/tests/kernel/kqueue/read/t_pipe.c
cvs rdiff -u -r1.6 -r1.7 src/tests/kernel/kqueue/write/t_pipe.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Home |
Main Index |
Thread Index |
Old Index