Re: kern/58458: sys/uvm/uvm_pdpolicy_clock.c:450: diagassert failed "(pg->pqflags & (PQ_INTENT_MASK | PQ_INTENT_S ET)) != (PQ_INTENT_D | PQ_INTENT_SET)"

["Tobias Nygren via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR kern/58458; it has been noted by GNATS.

From: Tobias Nygren <tnn%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/58458: sys/uvm/uvm_pdpolicy_clock.c:450: diagassert failed
 "(pg->pqflags & (PQ_INTENT_MASK | PQ_INTENT_S ET)) != (PQ_INTENT_D | PQ_INTENT_SET)"
Date: Sat, 5 Sep 2026 20:24:05 +0200

 Begin forwarded message:
 
 Date: Sat, 5 Sep 2026 16:53:05 +0000
 From: "Thor Lancelot Simon" <tls%netbsd.org@localhost>
 To: source-changes%NetBSD.org@localhost
 Subject: CVS commit: src/sys/uvm
 
 
 Module Name:	src
 Committed By:	tls
 Date:		Sat Sep  5 16:53:05 UTC 2026
 
 Modified Files:
 	src/sys/uvm: uvm_pdpolicy_clock.c uvm_pdpolicy_clockpro.c
 
 Log Message:
 Fix a very brief race which could cause page states to be corrupted.
 
 Observed under heavy physio load from an 8-way parallel dump|restore
 workload used in filesystem testing - manifested as intents being
 scribbled over while the interlock was momentarily not held
 in uvmpdpol_selectvictim.  I've attempted to apply the same fix to
 clockpro, which looks like it needs it too, but clockpro was on fire
 when I got there and I didn't put it out (still does not compile).
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.42 -r1.43 src/sys/uvm/uvm_pdpolicy_clock.c
 cvs rdiff -u -r1.27 -r1.28 src/sys/uvm/uvm_pdpolicy_clockpro.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.