NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

PR/60026 CVS commit: src/external/cddl/osnet/dist/uts/common/fs/zfs



The following reply was made to PR kern/60026; it has been noted by GNATS.

From: "YAMAMOTO Takashi" <yamt%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/60026 CVS commit: src/external/cddl/osnet/dist/uts/common/fs/zfs
Date: Tue, 17 Mar 2026 02:19:51 +0000

 Module Name:	src
 Committed By:	yamt
 Date:		Tue Mar 17 02:19:51 UTC 2026
 
 Modified Files:
 	src/external/cddl/osnet/dist/uts/common/fs/zfs: zfs_vfsops.c
 
 Log Message:
 zfs: reject all mount op flags for now
 
 - our logic in zfs_vfsops.c is inconsistent. sometimes it checks
   uap->flags, sometimes vfsp->vfs_flag. (aka mnt_flag)
 
 - our userland tools (zfs, mount_zfs) currently don't seem to have
   a way to pass these flags anyway. (zmount in libzfs always passes
   0 to both of mount(2) 'flags' argument and 'uap->flags'. although
   it stores something in uap->mflag and uap->optptr, nothing uses
   them. it doesn't even set MS_OPTIONSTR. we don't implement
   MS_OPTIONSTR anyway.)
 
 this commit simply rejects them for safety. as these operations have
 never been implemented in NetBSD, it shouldn't have any impact to users.
 
 maybe someday we should fix these, but i guess it involves some
 ABI changes, which i'm not in a mood to do right now.
 
 related to PR/60026
 https://gnats.netbsd.org/60026
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.31 -r1.32 \
     src/external/cddl/osnet/dist/uts/common/fs/zfs/zfs_vfsops.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.
 



Home | Main Index | Thread Index | Old Index