PR/59872 CVS commit: [netbsd-11] src/sys

["Martin Husemann" <martin%netbsd.org@localhost>]

The following reply was made to PR kern/59872; it has been noted by GNATS.

From: "Martin Husemann" <martin%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/59872 CVS commit: [netbsd-11] src/sys
Date: Mon, 2 Feb 2026 19:58:45 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Mon Feb  2 19:58:44 UTC 2026
 
 Modified Files:
 	src/sys/dev/usb [netbsd-11]: if_urndis.c usb.h
 	src/sys/modules/if_urndis [netbsd-11]: if_urndis.ioconf
 
 Log Message:
 Pull up following revision(s) (requested by riastradh in ticket #178):
 
 	sys/dev/usb/if_urndis.c: revision 1.50
 	sys/dev/usb/usb.h: revision 1.125
 	sys/modules/if_urndis/if_urndis.ioconf: revision 1.2
 
 usb.h: Provide definitions for USB class 0xef: miscellaneous.
 
 Source: https://usb.org/defined-class-codes
 https://web.archive.org/web/20251216031858/https://usb.org/defined-class-codes
 
 PR kern/59872: urndis(4): missing support for some devices
 
 urndis(4): Match more interface ids.
 
 There are some others we should consider too, based on what OpenBSD,
 FreeBSD, and Linux match, but I haven't tested with these devices:
    class           subclass                        protocol
 1. 0x02 (CDC)      0x02 (abstract control model)   0xff (? rndis?)
 2. 0xef (misc)     0x01 (sync)                     0x01 (active)
 3. 0xef (misc)     0x04 (rndis)                    0x03 (wimax)
 4. 0xef (misc)     0x04 (rndis)                    0x04 (wwan)
 
 Note: FreeBSD uses `UIPROTO_RNDIS' for (3) even though the USB-IF
 registry lists class 0xef, subclass 0x04, protocol 0x04 as `RNDIS
 over WiMAX'; likewise `UIPROTO_ACTIVESYNC' for (4) even though it's
 listed as `RNDIS over WWAN'.  My guess is that for class 0xef
 subclass 0x04, _any_ protocol will really be RNDIS, and it was a
 mistake for FreeBSD to use those protocol numbers (which context
 suggests were supposed to apply to different subclasses).
 
 PR kern/59872: urndis(4): missing support for some devices
 
 urndis(4): Attach at usbifif, not usbdevif, in the if_urndis module.
 
 We really ought to have a static type system for config(5) interface
 attributes to catch mistakes like this!
 
 Came up while trying to test a fix for:
 PR kern/59872: urndis(4): missing support for some devices
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.49 -r1.49.8.1 src/sys/dev/usb/if_urndis.c
 cvs rdiff -u -r1.124 -r1.124.4.1 src/sys/dev/usb/usb.h
 cvs rdiff -u -r1.1 -r1.1.36.1 src/sys/modules/if_urndis/if_urndis.ioconf
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.