PR/59587 CVS commit: src/usr.bin/ftp

["Luke Mewburn" <lukem%netbsd.org@localhost>]

The following reply was made to PR bin/59587; it has been noted by GNATS.

From: "Luke Mewburn" <lukem%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/59587 CVS commit: src/usr.bin/ftp
Date: Sat, 6 Dec 2025 06:20:23 +0000

 Module Name:	src
 Committed By:	lukem
 Date:		Sat Dec  6 06:20:23 UTC 2025
 
 Modified Files:
 	src/usr.bin/ftp: extern.h ftp.c util.c version.h
 
 Log Message:
 ftp: fix ascii transfers with progress bar
 
 Handle stdio interruption by signals and improve error handling
 in getc() and putc() on the control and data channels.
 Provide ftp_getc() and ftp_putc() wrappers that:
 - Retry the operation on EINTR or EAGAIN instead of failing.
 - Store other error codes in a return variable separate to errno,
   and use that variable in ferror() handling, for more correct
   error messages.
 
 Fixes the progress bar display in ascii mode transfers.
 
 (Note that I haven't fixed interrupted reads from stdin or
 writes to ttyout; that's a much larger refactor that's out of scope).
 
 Fix PR bin/59587 from Johnny Billquist, with the fix
 inspired by the patch in that PR.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.84 -r1.85 src/usr.bin/ftp/extern.h
 cvs rdiff -u -r1.178 -r1.179 src/usr.bin/ftp/ftp.c
 cvs rdiff -u -r1.168 -r1.169 src/usr.bin/ftp/util.c
 cvs rdiff -u -r1.100 -r1.101 src/usr.bin/ftp/version.h
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.