Re: port-xen/58561 (panic: kernel diagnostic assertion "x86_read_psl() == 0" failed: file "/home/netbsd/10/src/sys/arch/x86/x86/pmap.c", line 3581)

[riastradh%NetBSD.org@localhost]

Synopsis: panic: kernel diagnostic assertion "x86_read_psl() == 0" failed: file "/home/netbsd/10/src/sys/arch/x86/x86/pmap.c", line 3581

Responsible-Changed-From-To: port-xen-maintainer->bouyer
Responsible-Changed-By: riastradh%NetBSD.org@localhost
Responsible-Changed-When: Tue, 13 May 2025 15:30:14 +0000
Responsible-Changed-Why:
bouyer, can you take a look?

+cc cherry, who added the assertion back in 2011 with the cherry-xenmp
merge.

It's possible this is just some code path that does x86_disable_intr
without a necessary x86_read/write_psl around it to save and restore
the interrupt-disabled flag.  But I think we've only seen it on Xen
so far (see also dup https://gnats.netbsd.org/57543), which might help
to narrow it down.

This #ifndef XENPV x86_disable/enable_intr looks suspicious but I have
only superficially skimmed it and I have no idea what's going on:

https://nxr.netbsd.org/xref/src/sys/arch/amd64/amd64/trap.c?r=1.129#554

(This bug has been biting mollari a lot lately, happened again today.)