NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

PR/59321 CVS commit: src/sys/sys



The following reply was made to PR port-sparc/59321; it has been noted by GNATS.

From: "Taylor R Campbell" <riastradh%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/59321 CVS commit: src/sys/sys
Date: Tue, 22 Apr 2025 01:34:38 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Tue Apr 22 01:34:38 UTC 2025
 
 Modified Files:
 	src/sys/sys: atomic.h
 
 Log Message:
 sys/atomic.h: Fix hashlocked atomic stores, e.g. on sparc and hppa.
 
 Casting (uint32_t *)p does not actually round p down to a mulitple of
 sizeof(uint32_t)!  Oops.
 
 Likely fix for:
 
 PR port-sparc/59321: t_npf tests are failing
 
 and probably various other sparc and hppa issues.  (I have not been
 able to reproduce this failure, but the evidence from the assertion
 output is that the atomic_load_* calls are coming from inside the
 atomic.h house -- and there are only two of those outside macro
 expansions, and they're both in __do_atomic_store.)
 
 Now it would be nice if the stack trace went a little further than
 the kern_assert call so I didn't have to puzzle over that one to
 figure out where it was coming from...
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.26 -r1.27 src/sys/sys/atomic.h
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.
 


Home | Main Index | Thread Index | Old Index