Re: xsrc/58133: X server crashes; radeon 5450; modesetting

[Rhialto <rhialto%falu.nl@localhost>]

The following reply was made to PR xsrc/58133; it has been noted by GNATS.

From: Rhialto <rhialto%falu.nl@localhost>
To: matthew green <mrg%eterna23.net@localhost>
Cc: Rhialto <rhialto%falu.nl@localhost>, xsrc-manager%netbsd.org@localhost,
	gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost,
	gnats-bugs%netbsd.org@localhost
Subject: Re: xsrc/58133: X server crashes; radeon 5450; modesetting
Date: Sat, 11 May 2024 23:32:47 +0200

 Some observations:
 
 The destination variable "ptr" comes from
 r600_buffer_map_sync_with_rings() which seems to map a buffer (similar
 to the crashes arount glamor_get_vbo_space()).
 
 Stack frame #2 makes no sense:
 #2  0x000073c6e4984742 in store_shader ()
     at /usr/xsrc/external/mit/MesaLib.old/dist/src/gallium/drivers/r600/r600_shader.c:209
 
 204	/* Check if the bytecode has already been built. */
 	if (!shader->shader.bc.bytecode) {
 		r = r600_bytecode_build(&shader->shader.bc);
 		if (r) {
 			R600_ERR("building bytecode failed !\n");
 209			goto error;
 		}
 	}
 
 since line 209 is in a different function and there is no call to
 store_shader() there.
 
 And, after I gave a 'continue' command in gdb to let X crash, it
 continued where it left off seemingly without issues...
 
 I didn't check signal handers; maybe the other segvs are supposed to be
 "repaired" like this one seems to have been? (just wildly speculating)