install/58176: sysinst doesn't escape spaces in /etc/fstab

[rwhitlock22%gmail.com@localhost]

>Number:         58176
>Category:       install
>Synopsis:       sysinst doesn't escape spaces in /etc/fstab
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    install-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Apr 20 02:30:00 +0000 2024
>Originator:     Robert Whitlock
>Release:        NetBSD 10.0
>Organization:
>Environment:
NetBSD 10.0 amd64 GENERIC
>Description:
After booting into the NetBSD 10.0 installer, I dropped down into the shell to create some partitions with gpt(8), and I gave them labels with spaces in them, like "NetBSD 10.0". I installed NetBSD 10.0 onto one of the partitions and selected the "preconfigured wedges" option. When I booted up the installed system, I was greeted with a screenful of errors from fsck and mount about /etc/fstab and I was dropped into single user mode with a read-only root partition.

It turned out that the problem was that sysinst(8) didn't escape the spaces when it wrote

NAME=NetBSD 10.0 / ffs rw 1 1

and similarly for the other partitions, and as whitespace is a field delimiter, this confused programs reading that file.
>How-To-Repeat:
See above.
>Fix:
Make sysinst escape spaces in NAME values when writing /etc/fstab.