Re: kern/58149: aarch64: Cannot return from a signal handler if SP was misaligned when the signal arrived

[Nick Hudson <nick.hudson%gmx.co.uk@localhost>]

The following reply was made to PR kern/58149; it has been noted by GNATS.

From: Nick Hudson <nick.hudson%gmx.co.uk@localhost>
To: gnats-bugs%netbsd.org@localhost, kern-bug-people%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/58149: aarch64: Cannot return from a signal handler if SP
 was misaligned when the signal arrived
Date: Sun, 14 Apr 2024 08:31:16 +0100

 Hi,
 
 On 14/04/2024 04:40, pho%cielonegro.org@localhost wrote:
 [...]
 
 >> Synopsis:       aarch64: Cannot return from a signal handler if SP was =
 misaligned when the signal arrived
 
 Good catch.
 
 >> Fix:
 > Apply this patch:
 > https://github.com/NetBSD/src/commit/f672806f26384c093c73b4ee0fb94f1fa30=
 9ca4a
 
 
 	sp -=3D sizeof(ucontext_t);
 	sp -=3D roundup(sizeof(ucontext_t), 16);
 
 I'd prefer a compile time assert for the sizeof of ucontext_t... In fact
 it already exists in cpu_machdep.c
 
 https://nxr.netbsd.org/xref/src/sys/arch/aarch64/aarch64/cpu_machdep.c#170
 
 
 
 Thanks,
 Nick