Re: misc/58098: build.sh release fails due to missing METALOG entries

[Rob Whitlock <rwhitlock22%gmail.com@localhost>]

The following reply was made to PR misc/58098; it has been noted by GNATS.

From: Rob Whitlock <rwhitlock22%gmail.com@localhost>
To: Martin Husemann <martin%duskware.de@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: misc/58098: build.sh release fails due to missing METALOG entries
Date: Mon, 8 Apr 2024 10:19:12 -0400

 > On Apr 5, 2024, at 8:47 AM, Martin Husemann <martin%duskware.de@localhost> =
 wrote:
 >=20
 > On Fri, Apr 05, 2024 at 08:15:35AM -0400, Rob Whitlock wrote:
 >> Assuming that you meant that deleting -U would reproduce the problem,
 >> this is incorrect.
 >=20
 > No, he meant that your reproduction instruction where unecessarily =
 complex
 > and just running the 3 operations tools, modules, release in that =
 order
 > would reproduce it - which is probably true and points at the =
 "modules"
 > operation leaving a broken METALOG file.
 
 I see. I can confirm that just running those three operations does =
 reproduce the problem.
 
 > This is a bug and should be fixed.
 
 I have included a patch below that fixes the problem, as well as a typo =
 and it also writes the owner and group for other directories, which were =
 missing in the METALOG. I also included the mode, even though 0755 is =
 the default and it was being written into the METALOG already.
 
 The patch does not address the issue that directories are written to =
 METALOG redundantly, however this doesn't seem to cause an issue because =
 METLOG.sanitized is created without the duplicates.
 
 > My earlier point (slightly unrelated to this bug) is that "release" is =
 enough
 > for this whole thing, you do neither need "tools" nor "modules".
 >=20
 > The default operation I use for everything but very special cases is =
 "distsets".
 >=20
 > So you could collapse your setting to just
 >=20
 > 	build.sh ..... distsets kernel=3D....
 >=20
 > and work around the bug that way.
 >=20
 > Martin
 
 That's good to know, thanks.
 
 Index: share/mk/bsd.kmodule.mk
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/src/share/mk/bsd.kmodule.mk,v
 retrieving revision 1.81
 diff -r1.81 bsd.kmodule.mk
 209c209
 < # Ensure these are recorded properly in METALOG on unprived installes:
 ---
 > # Ensure these are recorded properly in METALOG on unprived installs:
 242a243,244
 > 	echo '. type=3Ddir uname=3Droot gname=3Dwheel mode=3D0755' | =
 ${METALOG.add}
 > 	echo './stand type=3Ddir uname=3Droot gname=3Dwheel mode=3D0755' =
 | ${METALOG.add}
 245c247
 < 		${INSTALL_DIR} ${DESTDIR}$$d; \
 ---
 > 		${INSTALL_DIR} -o root -g wheel -m 0755 ${DESTDIR}$$d; \=