bin/58071: gnats send-pr.el fails to work with emacs 28.x

[he%NetBSD.org@localhost]

>Number:         58071
>Category:       bin
>Synopsis:       gnats send-pr.el fails to work with emacs 28.x
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Mar 24 11:15:00 +0000 2024
>Originator:     Havard Eidnes
>Release:        NetBSD 10.0_RC3
>Organization:
	I try...
>Environment:
System: NetBSD smistad.uninett.no 10.0_RC3 NetBSD 10.0_RC3 (GENERIC) #9: Mon Feb 5 17:38:53 CET 2024 he%smistad.uninett.no@localhost:/usr/obj/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:
	send-pr.el version 3.95 fails to load in emacs 28.2 with:

defconst: Invalid function: `(("Category" send-pr::set-categories (,(or (gnats::get-config "DEFAULT_CATEGORY") nil)) enum) ("Class" (("sw-bug") ("doc-bug") ("change-request") ("support")) (,(or (gnats::get-config "DEFAULT_CLASS") 0)) enum) ("Confidential" (("yes") ("no")) (,(or (gnats::get-config "DEFAULT_CONFIDENTIAL") 1)) enum) ("Severity" (("non-critical") ("serious") ("critical")) (,(or (gnats::get-config "DEFAULT_SEVERITY") 1)) enum) ("Priority" (("low") ("medium") ("high")) (,(or (gnats::get-config "DEFAULT_PRIORITY") 1)) enum) ("Release" nil (,(or (gnats::get-config "DEFAULT_RELEASE") "<NetBSD-current source date>")) text) ("Submitter-Id" nil (,(or (gnats::get-config "SUBMITTER") "net")) text) ("Synopsis" nil nil text (lambda (a b c) (gnats::set-mail-field "Subject" c))))

	This comes from this part in send-pr.el:

;;; Ideally we would get all the following values from a central database
;;; during runtime instead of having them here in the code.
;;;
(defconst send-pr::fields
  (` (("Category" send-pr::set-categories
       (, (or (gnats::get-config "DEFAULT_CATEGORY") nil)) enum)
      ("Class" (("sw-bug") ("doc-bug") ("change-request") ("support"))
       (, (or (gnats::get-config "DEFAULT_CLASS") 0)) enum)
      ("Confidential" (("yes") ("no"))
       (, (or (gnats::get-config "DEFAULT_CONFIDENTIAL") 1)) enum)
      ("Severity" (("non-critical") ("serious") ("critical"))
       (, (or (gnats::get-config "DEFAULT_SEVERITY") 1)) enum)
      ("Priority" (("low") ("medium") ("high"))
       (, (or (gnats::get-config "DEFAULT_PRIORITY") 1)) enum)
      ("Release" nil
       (, (or (gnats::get-config "DEFAULT_RELEASE") "<NetBSD-current source date>"))
       text)
      ("Submitter-Id" nil
       (, (or (gnats::get-config "SUBMITTER") "net")) text)
      ("Synopsis" nil nil text
       (lambda (a b c) (gnats::set-mail-field "Subject" c)))))
  "AList, keyed on the name of the field, of:
1) The field name.
2) The list of completions.  This can be a list, a function to call, or nil.
3) The default value.
4) The type of the field.
5) A sub-function to call when changed.")

	My send-pr.el file is dated November 1998, so has
	not changed since, and quite a bit of water has flowed
	into the ocean since then, and quite a few things have
	happened to GNU emacs since then too...

	This appears to be the same version
	we still distribute as part of send-pr in NetBSD.

>How-To-Repeat:
	Try to use M-x send-pr and watch it fail.
>Fix:
	Sorry, don't know.