Re: kern/57694: rge(4) hang

[Michael van Elst <mlelstv%serpens.de@localhost>]

The following reply was made to PR kern/57694; it has been noted by GNATS.

From: Michael van Elst <mlelstv%serpens.de@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/57694: rge(4) hang
Date: Sat, 16 Dec 2023 13:38:25 +0100

 The following patch helped here:
 
 --- sys/dev/pci/if_rge.c        19 Oct 2023 23:43:40 -0000      1.28
 +++ sys/dev/pci/if_rge.c        16 Dec 2023 12:33:04 -0000
 @@ -1404,24 +1404,14 @@ rge_txeof(struct rge_softc *sc)
  
         sc->rge_ldata.rge_txq_considx = cons;
  
 -#if 0
 -       if (ifq_is_oactive(&ifp->if_snd))
 -               ifq_restart(&ifp->if_snd);
 -       else if (free == 2)
 -               ifq_serialize(&ifp->if_snd, &sc->sc_task);
 -       else
 -               ifp->if_timer = 0;
 -#else
 -#if 0
 +       if (free == 2)
 +               rge_txstart(&sc->sc_task, sc);
 +
 +       CLR(ifp->if_flags, IFF_OACTIVE);
         if (!IF_IS_EMPTY(&ifp->if_snd))
                 rge_start(ifp);
         else
 -       if (free == 2)
 -               if (0) { rge_txstart(&sc->sc_task, sc); }
 -       else
 -#endif
                 ifp->if_timer = 0;
 -#endif
  
         return (1);
  }
 
 
 -- 
                                 Michael van Elst
 Internet: mlelstv%serpens.de@localhost
                                 "A potential Snark may lurk in every tree."