NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/57467: zfs cannot umount snapshots once access it via /usr/.zfs/shapshots/ ....



The following reply was made to PR kern/57467; it has been noted by GNATS.

From: Sergio de Almeida Lenzi <nervoso%k1.com.br@localhost>
To: gnats-bugs%netbsd.org@localhost, kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
        netbsd-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/57467: zfs cannot umount snapshots once access it via
 /usr/.zfs/shapshots/ ....
Date: Mon, 19 Jun 2023 18:34:16 -0300

 --=-WwcHOQLlyv247kaIWdFa
 Content-Type: text/plain; charset="UTF-8"
 Content-Transfer-Encoding: 8bit
 
 Em sex, 2023-06-16 às 07:55 +0000, J. Hannken-Illjes escreveu:
 > The following reply was made to PR kern/57467; it has been noted by GNATS.
 > From: "J. Hannken-Illjes" <hannken%mailbox.org@localhost>To: NetBSD GNATS <gnats-bugs%netbsd.org@localhost>Cc: Subject: Re: kern/57467: zfs cannot umount snapshots once access it via /usr/.zfs/shapshots/ ....Date: Fri, 16 Jun 2023 09:53:53 +0200
 >  > On 16. Jun 2023, at 05:55, David Holland <dholland-bugs%netbsd.org@localhost> wrote: >  > The following reply was made to PR kern/57467; it has been noted by GNATS. >  > From: David Holland <dholland-bugs%netbsd.org@localhost> > To: gnats-bugs%netbsd.org@localhost
 >  > Cc:  > Subject: Re: kern/57467: zfs cannot umount snapshots once access it via > /usr/.zfs/shapshots/ .... > Date: Fri, 16 Jun 2023 03:53:04 +0000 >  > On Wed, Jun 14, 2023 at 03:15:02PM +0000, Michael van Elst wrote: >>> If I patch zfsmount to set the VV_ROOT  will it work? >>  >> vnodes are part of the kernel. I don't know if that will work or if this >> wreaks havoc... >  > Could go either way. >  > Without VV_ROOT, what happens with getcwd and/or looking up .. from > the top? Seems likely to be bust.  ZFS tries to hide this mount as much as possible.  When NFS exporting a ZFS file system the control directory AND the snapshots here are on the same export.  See zfs_vnops.c, lines 2071 and 3105 for ".." and getcwd support.  What is the benefit of unmounting snapshots from the snapshot control directory?  They will remount on the next lookup anyway.  -- J. Hannken-Illjes - hannken%mailbox.org@localhost
 >  
 I was just thinking in zfs make the same behavior as in FreeBSD... that it does not show the mountpoints on snapshots,
 but I do now now if FreeBSD keep them mounted, just do not show.
 
 besides... if I leave the snapshot directory... and come back later... it remounts the snapshot again... 
 We have lots NetBSD system running on ZFS that does not reboots for months  in crytical mission as fileservers 
 exporting smb  on top of zfs. for 32 tb on 4 16TB drives.. the users sometimes "misses"  files and they have a "smbshare" named "backup", that
 walks over the snapshot tree...  when they do that, after some time, there are a great number of mount points... 
 I was just wondering if the open files, would exsauted and the server would lock or reboot...
 we also use the zfs sync=disabled.. and always with a 2 mirror drives on every zpool...
 
 --=-WwcHOQLlyv247kaIWdFa
 Content-Type: text/html; charset="utf-8"
 Content-Transfer-Encoding: quoted-printable
 
 <html dir=3D"ltr"><head></head><body style=3D"text-align:left; direction:lt=
 r;" bgcolor=3D"#ffffff" text=3D"#000000" link=3D"#0000ee" vlink=3D"#0000ee"=
 ><div>Em sex, 2023-06-16 =C3=A0s 07:55 +0000, J. Hannken-Illjes escreveu:</=
 div><blockquote type=3D"cite" style=3D"margin:0 0 0 .8ex; border-left:2px #=
 729fcf solid;padding-left:1ex"><pre>The following reply was made to PR kern=
 /57467; it has been noted by GNATS.</pre><pre><br></pre><pre>From: "J. Hann=
 ken-Illjes" &lt;</pre><a href=3D"mailto:hannken%mailbox.org@localhost";><pre>hannken@m=
 ailbox.org</pre></a><pre>&gt;</pre><pre>To: NetBSD GNATS &lt;</pre><a href=
 =3D"mailto:gnats-bugs%netbsd.org@localhost";><pre>gnats-bugs%netbsd.org@localhost</pre></a><pre>=
 &gt;</pre><pre>Cc: </pre><pre>Subject: Re: kern/57467: zfs cannot umount sn=
 apshots once access it via</pre><pre> /usr/.zfs/shapshots/ ....</pre><pre>D=
 ate: Fri, 16 Jun 2023 09:53:53 +0200</pre><pre><br></pre><pre> &gt; On 16. =
 Jun 2023, at 05:55, David Holland &lt;</pre><a href=3D"mailto:dholland-bugs=
 @netbsd.org"><pre>dholland-bugs%netbsd.org@localhost</pre></a><pre>&gt; wrote:</pre><=
 pre> &gt; </pre><pre> &gt; The following reply was made to PR kern/57467; i=
 t has been noted by GNATS.</pre><pre> &gt; </pre><pre> &gt; From: David Hol=
 land &lt;</pre><a href=3D"mailto:dholland-bugs%netbsd.org@localhost";><pre>dholland-bu=
 gs%netbsd.org@localhost</pre></a><pre>&gt;</pre><pre> &gt; To: </pre><a href=3D"mailt=
 o:gnats-bugs%netbsd.org@localhost"><pre>gnats-bugs%netbsd.org@localhost</pre></a><pre><br></pre=
 ><pre> &gt; Cc: </pre><pre> &gt; Subject: Re: kern/57467: zfs cannot umount=
  snapshots once access it via</pre><pre> &gt; /usr/.zfs/shapshots/ ....</pr=
 e><pre> &gt; Date: Fri, 16 Jun 2023 03:53:04 +0000</pre><pre> &gt; </pre><p=
 re> &gt; On Wed, Jun 14, 2023 at 03:15:02PM +0000, Michael van Elst wrote:<=
 /pre><pre> &gt;&gt;&gt; If I patch zfsmount to set the VV_ROOT  will it wor=
 k?</pre><pre> &gt;&gt; </pre><pre> &gt;&gt; vnodes are part of the kernel. =
 I don't know if that will work or if this</pre><pre> &gt;&gt; wreaks havoc.=
 ..</pre><pre> &gt; </pre><pre> &gt; Could go either way.</pre><pre> &gt; </=
 pre><pre> &gt; Without VV_ROOT, what happens with getcwd and/or looking up =
 .. from</pre><pre> &gt; the top? Seems likely to be bust.</pre><pre> </pre>=
 <pre> ZFS tries to hide this mount as much as possible.  When NFS exporting=
 </pre><pre> a ZFS file system the control directory AND the snapshots here =
 are</pre><pre> on the same export.</pre><pre> </pre><pre> See zfs_vnops.c, =
 lines 2071 and 3105 for ".." and getcwd support.</pre><pre> </pre><pre> Wha=
 t is the benefit of unmounting snapshots from the snapshot control</pre><pr=
 e> directory?  They will remount on the next lookup anyway.</pre><pre> </pr=
 e><pre> --</pre><pre> J. Hannken-Illjes - </pre><a href=3D"mailto:hannken@m=
 ailbox.org"><pre>hannken%mailbox.org@localhost</pre></a><pre><br></pre><pre> </pre></=
 blockquote><div>I was just thinking in zfs make the same behavior as in Fre=
 eBSD... that it does not show the mountpoints on snapshots,</div><div>but I=
  do now now if FreeBSD keep them mounted, just do not show.</div><div><br><=
 /div><div>besides... if I leave the snapshot directory... and come back lat=
 er... it remounts the snapshot again... </div><div>We have lots NetBSD syst=
 em running on ZFS that does not reboots for months  in crytical mission as =
 fileservers </div><div>exporting smb  on top of zfs. for 32 tb on 4 16TB dr=
 ives.. the users sometimes "misses"  files and they have a "smbshare" named=
  "backup", that</div><div>walks over the snapshot tree...  when they do tha=
 t, after some time, there are a great number of mount points... </div><div>=
 I was just wondering if the open files, would exsauted and the server would=
  lock or reboot...</div><div>we also use the zfs sync=3Ddisabled.. and alwa=
 ys with a 2 mirror drives on every zpool...</div><div><br></div></body></ht=
 ml>
 
 --=-WwcHOQLlyv247kaIWdFa--
 



Home | Main Index | Thread Index | Old Index