bin/57469: C attribute problems in lib/libc/time/zic.c

[lloyd%must-have-coffee.gen.nz@localhost]

>Number:         57469
>Category:       bin
>Synopsis:       C attribute problems in lib/libc/time/zic.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jun 15 02:25:00 +0000 2023
>Originator:     Lloyd Parkes
>Release:        10.0_BETA
>Organization:
Must Have Coffee
>Environment:
Linux riftsweeper.must-have-coffee.gen.nz 6.3.4-arch2-1 #1 SMP PREEMPT_DYNAMIC Mon, 29 May 2023 13:58:34 +0000 x86_64 GNU/Linux
>Description:
When building tools with "build.sh ... tools" on my Arch Linux laptop, the build fails with errors like the following

/home/lloyd/NetBSD/netbsd-10/src/lib/libc/time/zic.c:475:1: warning: 'noreturn' attribute ignored [-Wattributes]
  475 | static ATTRIBUTE_NORETURN void
      | ^~~~~~
/home/lloyd/NetBSD/netbsd-10/src/lib/libc/time/zic.c:475:27: error: expected identifier or '(' before 'void'
  475 | static ATTRIBUTE_NORETURN void
      |                           ^~~~

This is because a bunch of functions are defined as "static ATTRIBUTE_NORETURN ..." instead of "ATTRIBUTE_NORETURN static ...". The latter is required for C23.
>How-To-Repeat:
Build netbsd-10 on a bleeding edge system.

>Fix:
Just pullup lib/libc/time/zic.c from current. The only difference between the two versions is the required support for C23.