Re: port-pmax/57245: (Most?) MIPS Ports: Error: symbol type "gnu_indirect_function" is not supported by MIPS targets

[Jan-Benedict Glaw <jbglaw%lug-owl.de@localhost>]

The following reply was made to PR port-pmax/57245; it has been noted by GNATS.

From: Jan-Benedict Glaw <jbglaw%lug-owl.de@localhost>
To: gnats-bugs%netbsd.org@localhost, Christos Zoulas <christos%zoulas.com@localhost>
Cc: port-pmax-maintainer%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
	netbsd-bugs%netbsd.org@localhost
Subject: Re: port-pmax/57245: (Most?) MIPS Ports: Error: symbol type
 "gnu_indirect_function" is not supported by MIPS targets
Date: Mon, 27 Feb 2023 00:26:58 +0100

 On Sun, 2023-02-26 16:25:02 +0000, Martin Husemann <martin%duskware.de@localhost> wro=
 te:
 >  Possible issues: the tooldir version of gas is configured differently
 >  when building on linux? You have something in mk.conf that causes the
 >  build failure?
 
 Not yet done with bisecting, but in the remaining range, I suspect
 this commit:
 
 commit 0d328f22aad77fab31f5e0ca8a976746002f4db0
 Author: christos <christos%NetBSD.org@localhost>
 Date:   Wed Jan 25 19:08:41 2023 +0000
 
     disable no ifuncs no mips error for now.
 
 diff --git a/external/gpl3/binutils/dist/gas/config/obj-elf.c b/external/gp=
 l3/binutils/dist/gas/config/obj-elf.c
 index e5ab8514de74..d3fe949adeaa 100644
 --- a/external/gpl3/binutils/dist/gas/config/obj-elf.c
 +++ b/external/gpl3/binutils/dist/gas/config/obj-elf.c
 @@ -2395,10 +2395,12 @@ obj_elf_type (int ignore ATTRIBUTE_UNUSED)
           && bed->elf_osabi !=3D ELFOSABI_FREEBSD)
         as_bad (_("symbol type \"%s\" is supported only by GNU "
                   "and FreeBSD targets"), type_name);
 +#ifndef __NetBSD__
        /* MIPS targets do not support IFUNCS.  */
        else if (bed->target_id =3D=3D MIPS_ELF_DATA)
         as_bad (_("symbol type \"%s\" is not supported by "
                      "MIPS targets"), type_name);
 +#endif
        elf_tdata (stdoutput)->has_gnu_osabi |=3D elf_gnu_osabi_ifunc;
        type =3D BSF_FUNCTION | BSF_GNU_INDIRECT_FUNCTION;
      }
 
 
 That won't fly for cross-compilation. I'll finish bisecting this
 initial issue and then continue with the other MIPS-related issues
 mentioned in this ticket. (I'd probably open a new ticket for those?)
 
 Thanks,
   Jan-Benedict
 --=20