install/57132: sysinst doesn't handle pm->pstart properly

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

>Number:         57132
>Category:       install
>Synopsis:       sysinst doesn't handle pm->pstart properly
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    install-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Dec 23 12:45:00 +0000 2022
>Originator:     Izumi Tsutsui
>Release:        NetBSD 10.0_BETA 202212180050Z
>Organization:
>Environment:
System: NetBSD 9.3 (INSTALL) x68k
Architecture: m68k
Machine: x68k
>Description:
sysinst on NetBSD/x68k 10.0_BETA still has the following problems:
 https://gist.github.com/tsutsui/d6c6ab07d5fc62d8381fbdad8b6a8633
 - swap partition (shoud be at b: ?) is not shown on disklabel editor (0:53)
 - if swap partition is added manually partition c: seems corrupted (1:15)
 - so I delete the c: then a: seems corrupted (1:40)
on ports that have pm->pstart>0 (to have reserved sectors before NetBSD partition)

>How-To-Repeat:
(build and install pkgsrc/emulators/nono)
echo 'vmtype = x68030' > nono.cfg
echo 'ram-size = 12' >> nono.cfg
echo 'sram-sync-ramsize = 1' >> nono.cfg
ftp http://nycdn.netbsd.org/pub/NetBSD-daily/netbsd-10/latest/x68k/installation/floppy/sysinst1.fs
ftp http://nycdn.netbsd.org/pub/NetBSD-daily/netbsd-10/latest/x68k/installation/floppy/sysinst2.fs
dd if=/dev/zero of=hdd.img bs=1m count=1024
nono
(^C or quit by [File]->[Exit] menu once after SRAM.DAT is created)
nono -f -c nono.cfg -V spc0-id0-image=hd,hdd.img -V fd0-image=sysinst1.fs -V fd1-image=sysinst2.fs

(sysinst will start on nono)

"a: Install NetBSD to hard disk"
"b: Yes"
"a: sd0 (1.0G, NONO SCSIHD)"
"a: Set sizes of NetBSD partitions"
"x: Go on.  Free space 1437632 sec."

Then you can see
- no swap partition on the disklabel editor.
- adding or deleting partitions makes partition table mangled.
- selecting "x: Partition sizes ok" then sysinst complains:
 "The order of partition 1 () is wrong.  Edit again?"

>Fix:
It would be great to have design descriptoin of data structure
in edit_and_check_label() etc. to investigate it.

---
Izumi Tsutsui