NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: bin/56862: boot.cfg bug with userconf



The following reply was made to PR bin/56862; it has been noted by GNATS.

From: Valery Ushakov <uwe%stderr.spb.ru@localhost>
To: RVP <rvp%SDF.ORG@localhost>
Cc: gnats-bugs%netbsd.org@localhost, Thomas Klausner <wiz%NetBSD.org@localhost>
Subject: Re: bin/56862: boot.cfg bug with userconf
Date: Mon, 6 Jun 2022 01:03:21 +0300

 On Sun, Jun 05, 2022 at 20:59:01 +0000, RVP wrote:
 
 > OK, if you want to boot the default entry, then the simplest thing to
 > do here is to have a special arg like "default" for the "boot" command:
 
 Thinking about it a bit, I guess that it complicates things without
 much benefit.  There is "menu" command (introduced in the same commit)
 that gets you back into the menu choice, so you can then select the
 entry you want.
 
 And to get to the boot prompt you have to make some effort (so it's
 unlikely you end up there by accident), and "help" is available
 
 Also, #ifndef SMALL around that original hunk was ... not thought
 through, as it doesn't just compile out some functionality, but
 changes the semantic of the command based on which boot block you use.
 
 So I think your original patch to to drop that hunk is the right
 course of action, but we need to find all the places - your patch
 changes sys/arch/i386/stand/efiboot/boot.c but the other PR is about
 the original change in stand/boot that was later cloned to efiboot it
 seems.
 
 -uwe
 


Home | Main Index | Thread Index | Old Index