NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/55691: rump kernels log "rn_init: radix functions require max_keylen be set"



The following reply was made to PR kern/55691; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: Andreas Gustafsson <gson%gson.org@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: kern/55691: rump kernels log "rn_init: radix functions require
 max_keylen be set"
Date: Sat, 17 Oct 2020 14:51:46 +0200

 On Sat, Oct 17, 2020 at 03:41:17PM +0300, Andreas Gustafsson wrote:
 > There's no point in introducing a boolean to verify that the loop has
 > run already, because the above code is immediately after the loop, so
 > it is only reached if the loop has run (in the _KERNEL case; in the
 > not-_KERNEL case, there is no loop).
 
 I got it - the code is shared with userland (e.g. routed uses it and
 manually sets max_keylen upfront).
 
 Yes, your suggested change looks good.
 
 Martin
 


Home | Main Index | Thread Index | Old Index