Re: lib/55719 (Unwind tables for signal trampoline on amd64 are incorrect)

[Nikhil Benesch <nikhil.benesch%gmail.com@localhost>]

The following reply was made to PR lib/55719; it has been noted by GNATS.

From: Nikhil Benesch <nikhil.benesch%gmail.com@localhost>
To: Nick Hudson <nick.hudson%gmx.co.uk@localhost>
Cc: Kamil Rytarowski <kamil%netbsd.org@localhost>, gnats-bugs%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
	netbsd-bugs%netbsd.org@localhost, Andrew Cagney <andrew.cagney%gmail.com@localhost>
Subject: Re: lib/55719 (Unwind tables for signal trampoline on amd64 are incorrect)
Date: Mon, 12 Oct 2020 11:13:29 -0400

 Ah, indeed, I copied the naming from the MIPS port, which does seem to
 be the outlier in using the "OFFSETOF_" prefix for these macros.
 
 On Mon, Oct 12, 2020 at 10:57 AM Nick Hudson <nick.hudson%gmx.co.uk@localhost> wrote:
 >
 > On 12/10/2020 15:01, Kamil Rytarowski wrote:
 > [snip]
 >
 > Good job.
 >
 > > Andrew, is this ready to commit?
 > >
 > > http://netbsd.org/~kamil/patch-00283-amd64-__sigtramp2-cfi-unwinding.2.txt
 > >
 >
 > Is '_OFFSETOF_' really needed as a prefix?
 >
 >
 > nick@thinkbook:~/netbsd/nbcvs/src$ find lib/libc -name "genassym.cf"
 > -exec grep -H offsetof {} \; | grep -v _OFFSETOF | wc -l
 > 71
 > nick@thinkbook:~/netbsd/nbcvs/src$ find lib/libc -name "genassym.cf"
 > -exec grep -H offsetof {} \; | grep  _OFFSETOF | wc -l
 > 41
 > nick@thinkbook:~/netbsd/nbcvs/src$
 >
 >
 > Thanks,
 > Nick