[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: bin/55529: [PATCH] script(1): Enable proper playback [-p] of curses sessions
The other part of script [ recording ] implicitly assumes that
stdin is a tty. I have fixed that. Also, I added more error handling.
PR id: bin/55531.
This also makes other small changes
1. system_call() == -1 in place of the system_call() != 0 in termset
2. I liked the atexit(termreset) that was put in place of the
termreset calls at multiple places in my patch. However, an extra
termreset() is needed before the printf("Script started on %s", ...)
in the "case 'e'" portion of playback(). Unfortunately, this bit of
the test was done on FreeBSD, where, in absence of this extra
termreset(), script(1) was failing to put an extra carriage return at
the end of the session, making my shell prompt print shifted toward
the right after script(1) exited. Since termreset sets isterm = 0,
multiple calls to termreset are not too bad.
On 8/1/20, Soumendra Ganguly <soumendra%tamu.edu@localhost> wrote:
> The following reply was made to PR bin/55529; it has been noted by GNATS.
> From: Soumendra Ganguly <soumendra%tamu.edu@localhost>
> To: gnats-bugs%netbsd.org@localhost
> Subject: Re: bin/55529: [PATCH] script(1): Enable proper playback [-p] of
> curses sessions
> Date: Sat, 1 Aug 2020 22:05:58 -0500
> Thank you for committing the patch.
> Thank you for the suggestion. Henceforth, I will not send NetBSD
> patches using GitHub.
> Soumendra Ganguly
> On 8/1/20, Valery Ushakov <uwe%stderr.spb.ru@localhost> wrote:
> > The following reply was made to PR bin/55529; it has been noted by
> > From: Valery Ushakov <uwe%stderr.spb.ru@localhost>
> > To: gnats-bugs%netbsd.org@localhost
> > Cc: Christos Zoulas <christos%zoulas.com@localhost>
> > Subject: Re: bin/55529: [PATCH] script(1): Enable proper playback [-p]
> > curses sessions
> > Date: Sun, 2 Aug 2020 05:38:18 +0300
> > Sorry, I have misinterprepted what's going on. Please, ignore.
> > In my defense - please, please, please, don't use github to submit
> > patches. It takes multiple clicks to find the actual patch and then
> > it's "helpfully" highlighted in shades of pink and green that I
> > *cannot* see b/c I have mild deuteranomaly. I don't have problems
> > with traffic lights, but modern UI designs prefer pastel shades that
> > *are* a problem. I haven't found a way to change those colors or get
> > the actual diff.
> > -uwe
Main Index |
Thread Index |