Re: kern/54969: Disk cache is no longer flushed on shutdown

[Andreas Gustafsson <gson%gson.org@localhost>]

The following reply was made to PR kern/54969; it has been noted by GNATS.

From: Andreas Gustafsson <gson%gson.org@localhost>
To: "J. Hannken-Illjes" <hannken%eis.cs.tu-bs.de@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: kern/54969: Disk cache is no longer flushed on shutdown
Date: Wed, 19 Feb 2020 16:37:09 +0200

 J. Hannken-Illjes wrote:
 > Tried with sd0@vioscsi0 under qemu with some printfs and got:
 > 
 > $ shutdown -p now
 > ...
 > unmounting 0xffff9d635e36a008 / (/dev/sd0a)...
 > forcefully unmounting / (/dev/sd0a)...
 > sdclose: dev=0x400 (unit 0)
 > dk_close: dev=0x400 error=0 openmask=c0 b0
 > sd0: detached
 > scsibus0: detached
 > 
 > With "halt -p" I see the problem from this PR as the swap
 > device sd0b doesn't get closed.
 > 
 > Please report with the attached diff holding the printfs ...
 
 I can do that, but I'm not sure why it's needed as you seem to have
 already reproduced the problem locally using "halt -p".
 
 I may have caused some confusion by using the word "shutdown" in the
 PR subject - sorry about that.  I meant it as a reference to the
 general action of shutting the system down, not as a reference to the
 specific command shutdown(8).  Also, I said "halt -p" in the PR, but
 checking the logs, I see that the actual command used was a plain
 "halt" without the -p option.
 -- 
 Andreas Gustafsson, gson%gson.org@localhost