Re: port-sun3/54869: nfsserver module load failure on NetBSD/sun3

[Jason Thorpe <thorpej%me.com@localhost>]

The following reply was made to PR port-sun3/54869; it has been noted by GNATS.

From: Jason Thorpe <thorpej%me.com@localhost>
To: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: port-sun3/54869: nfsserver module load failure on NetBSD/sun3
Date: Sat, 18 Jan 2020 10:13:48 -0800

 > On Jan 18, 2020, at 9:26 AM, Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost> wrote:
 > 
 >> In this manner, I have a feeling that sun3 should define all
 >> exported pmap APIs in the common sun3/include/pmap.h,
 >> rather than sun3/sun3x specific headers.
 >> (though there is difficulty on pmap_prefer(9))
 > 
 > For netbsd-9, the attached diff makes nfsserver module work on 3/60:
 
 This seems reasonable.
 
 > 
 > ---
 > Index: sys/arch/sun3/include/pmap.h
 > ===================================================================
 > RCS file: /cvsroot/src/sys/arch/sun3/include/pmap.h,v
 > retrieving revision 1.32
 > diff -u -p -d -r1.32 pmap.h
 > --- sys/arch/sun3/include/pmap.h	11 Dec 2009 18:31:27 -0000	1.32
 > +++ sys/arch/sun3/include/pmap.h	18 Jan 2020 17:24:36 -0000
 > @@ -37,6 +37,12 @@
 > #endif	/* SUN3X */
 > 
 > #ifdef _KERNEL
 > +/*
 > + * Some pmap(9) API macros should be defined here for module(7)
 > + * because they are common between sun3 and sun3x. (see PR/54869)
 > + */
 > +#define	pmap_update(pmap)		/* nothing (yet) */
 > +
 > void pmap_procwr(struct proc *, vaddr_t, size_t);
 > #endif
 > 
 > Index: sys/arch/sun3/include/pmap3.h
 > ===================================================================
 > RCS file: /cvsroot/src/sys/arch/sun3/include/pmap3.h,v
 > retrieving revision 1.49
 > diff -u -p -d -r1.49 pmap3.h
 > --- sys/arch/sun3/include/pmap3.h	7 Jan 2013 16:58:09 -0000	1.49
 > +++ sys/arch/sun3/include/pmap3.h	18 Jan 2020 17:24:36 -0000
 > @@ -64,8 +64,6 @@ extern segsz_t pmap_wired_pages(pmap_t);
 > /* We use the PA plus some low bits for device mmap. */
 > #define pmap_phys_address(addr) 	(addr)
 > 
 > -#define	pmap_update(pmap)		/* nothing (yet) */
 > -
 > /* Map a given physical region to a virtual region */
 > extern vaddr_t pmap_map(vaddr_t, paddr_t, paddr_t, int);
 > 
 > Index: sys/arch/sun3/include/pmap3x.h
 > ===================================================================
 > RCS file: /cvsroot/src/sys/arch/sun3/include/pmap3x.h,v
 > retrieving revision 1.29
 > diff -u -p -d -r1.29 pmap3x.h
 > --- sys/arch/sun3/include/pmap3x.h	3 Jun 2011 17:03:52 -0000	1.29
 > +++ sys/arch/sun3/include/pmap3x.h	18 Jan 2020 17:24:36 -0000
 > @@ -53,8 +53,6 @@ segsz_t pmap_count(pmap_t, int);
 > /* We use the PA plus some low bits for device mmap. */
 > #define pmap_phys_address(addr) 	(addr)
 > 
 > -#define	pmap_update(pmap)		/* nothing (yet) */
 > -
 > /* Map a given physical region to a virtual region */
 > vaddr_t pmap_map(vaddr_t, paddr_t, paddr_t, int);
 > 
 > 
 > ---
 > 
 > ---
 > Izumi Tsutsui
 > 
 
 -- thorpej