kern/54859: src/sys/dev/pci/if_rge.c: 2 * bad expression

[dcb314%hotmail.com@localhost]

>Number:         54859
>Category:       kern
>Synopsis:       src/sys/dev/pci/if_rge.c: 2 * bad expression
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jan 14 18:45:00 +0000 2020
>Originator:     David Binderman
>Release:        cvs-20200114
>Organization:
>Environment:
>Description:
1.

src/sys/dev/pci/if_rge.c:1870:38: style: Expression '(X & 0x80) == 0x2' is always false. [comparisonError]

Source code is

  if ((rge_read_phy_ocp(sc, 0xa420) & 0x0080) == 2)

2.

src/sys/dev/pci/if_rge.c:1429:38: style: Expression '(X & 0x80) == 0x3' is always false. [comparisonError]

Source code is

     if ((rge_read_phy_ocp(sc, 0xa420) & 0x0080) == 3)

>How-To-Repeat:

>Fix: