NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

PR/50206 CVS commit: src/sys/dev/mii

The following reply was made to PR kern/50206; it has been noted by GNATS.

From: "SAITOH Masanobu" <>
Subject: PR/50206 CVS commit: src/sys/dev/mii
Date: Wed, 20 Nov 2019 08:51:00 +0000

 Module Name:	src
 Committed By:	msaitoh
 Date:		Wed Nov 20 08:51:00 UTC 2019
 Modified Files:
 	src/sys/dev/mii: atphy.c mii_physubr.c miivar.h
 Log Message:
  Fix a bug that atphy(4) can't negotiate correctly when the media setting is
 neither auto nor 1000baseT. Use correct index for mii_media_table[].
  History: mii_anar() is first added in OpenBSD and ported to NetBSD. On NetBSD,
 only atphy(4) use this function. mii_physubr.c rev. 1.75 changed mii_anar()
 for simplify. It changed the argument from the ifmedia word to ifm_data used
 in our MII API, but the caller have not been changed. And then, PR kern/50206
 was reported and the caller was modified by me to prevent panic but it was not
 correct fix.
 To generate a diff of this commit:
 cvs rdiff -u -r1.24 -r1.25 src/sys/dev/mii/atphy.c
 cvs rdiff -u -r1.87 -r1.88 src/sys/dev/mii/mii_physubr.c
 cvs rdiff -u -r1.68 -r1.69 src/sys/dev/mii/miivar.h
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Home | Main Index | Thread Index | Old Index