NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

kern/54705: uaudio: move computing of the number of input channels under UAUDIO_DEBUG



>Number:         54705
>Category:       kern
>Synopsis:       uaudio: move computing of the number of input channels under UAUDIO_DEBUG
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 17 17:40:00 +0000 2019
>Originator:     Alexander Kuleshov
>Release:        NetBSD-current
>Organization:
Travelping
>Environment:
NetBSD localhost 9.99.17 NetBSD 9.99.17 (MY_KERN) #3: Sun Nov 17 18:10:31 +06 2019  alex@localhost:/usr/obj/sys/arch/amd64/compile/MY_KERN amd64
>Description:
Hello,

The uaudio_add_mixer() function from src/sys/dev/usb/uaudio.c contains computing of number of input channels, but its result is only used in DPRINTF macro which does the stuff only if UAUDIO_DEBUG is defined.

The patch is attached below. Can you take a look please:

Index: uaudio.c
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/uaudio.c,v
retrieving revision 1.162
diff -r1.162 uaudio.c
758c758
< 	int c, chs, ichs, ochs, i, o, bno, p, mo, mc, k;
---
> 	int c, chs, ochs, i, o, bno, p, mo, mc, k;
760a761,763
> #ifdef UAUDIO_DEBUG
>         int ichs;
> #endif
765c768
< 
---
> #ifdef UAUDIO_DEBUG
770c773
< 
---
> #endif


Thank you.
>How-To-Repeat:

>Fix:



Home | Main Index | Thread Index | Old Index