Re: PR/54093 CVS commit: src

[Takeshi Nakayama <nakayama%NetBSD.org@localhost>]

The following reply was made to PR port-sparc/54093; it has been noted by GNATS.

From: Takeshi Nakayama <nakayama%NetBSD.org@localhost>
To: joerg%bec.de@localhost
Cc: gnats-bugs%netbsd.org@localhost, martin%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
        netbsd-bugs%netbsd.org@localhost, gson%gson.org@localhost
Subject: Re: PR/54093 CVS commit: src
Date: Wed, 06 Nov 2019 14:34:20 +0900 (JST)

 >>> Joerg Sonnenberger <joerg%bec.de@localhost> wrote
 
 > >  I think static TLS area should align with p_align in elf program
 > >  header, not with sizeof(max_align_t).
 > 
 > We don't support non-standard alignments of TLS. Fixing that is
 > intrusive in the dynamic linker and I have no plan to do that ATM.
 
 Should we follow p_align for static linking?  Since it is now
 aligned with a value different from p_align, some atf tests fails
 on amd64 like sparc before the change.  Previously, p_align and
 sizeof(void *) had the same value on amd64 by chance.
 
 http://releng.netbsd.org/b5reports/amd64/commits-2019.11.html#2019.11.04.15.12.10
 	lib/csu/t_ifunc_static/ifunc_static
 	usr.bin/c++/t_call_once/call_once_static
 	usr.bin/c++/t_call_once2/call_once2_static
 	usr.bin/c++/t_cxxruntime/cxxruntime_static
 	usr.bin/c++/t_hello/hello_static
 	usr.bin/c++/t_pthread_once/pthread_once_static
 	usr.bin/c++/t_static_destructor/static_destructor_static
 
 > >  sizeof(max_align_t) is 12 on i386, it is not valid on roundup2.
 > >  This seems to cause some atf tests to fail.
 > 
 > That would be a separate bug on i386.
 
 For dynamic linking, I understood the change since you fixed to use
 roundup2 with alignof(max_align_t) instead of sizeof(max_align_t).
 
 -- Takeshi Nakayama