Re: pkg/54192: lang/rust build error

[Kamil Rytarowski <n54%gmx.com@localhost>]

The following reply was made to PR toolchain/54192; it has been noted by GNATS.

From: Kamil Rytarowski <n54%gmx.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/54192: lang/rust build error
Date: Wed, 16 Oct 2019 15:33:31 +0200

 On 16.10.2019 01:55, Joerg Sonnenberger wrote:
 > The following reply was made to PR toolchain/54192; it has been noted by=
  GNATS.
 >
 > From: Joerg Sonnenberger <joerg%bec.de@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc: toolchain-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
 > 	netbsd-bugs%netbsd.org@localhost, ben@pocket.services
 > Subject: Re: pkg/54192: lang/rust build error
 > Date: Wed, 16 Oct 2019 01:44:00 +0200
 >
 >   --lrZ03NoBR/3+SXJZ
 >   Content-Type: text/plain; charset=3Dus-ascii
 >   Content-Disposition: inline
 >
 >   On Tue, Oct 15, 2019 at 07:15:01PM +0000, coypu%sdf.org@localhost wrote:
 >   >  Here's a backtrace of the problem.
 >   >  (Rust 1.36, netbsd-current as of ~october 2019)
 >
 >   Try the attached patch. It's the only constellation that makes sense t=
 o
 >   me.
 >
 >   Joerg
 >
 >   --lrZ03NoBR/3+SXJZ
 >   Content-Type: text/plain; charset=3Dus-ascii
 >   Content-Disposition: attachment; filename=3D"lid-after-fork.diff"
 >
 >   diff -r 7e46460ebf1d sys/kern/kern_lwp.c
 >   --- a/sys/kern/kern_lwp.c	Tue Oct 15 06:58:12 2019 +0000
 >   +++ b/sys/kern/kern_lwp.c	Wed Oct 16 00:35:25 2019 +0200
 >   @@ -902,6 +902,8 @@
 >    	if ((flags & LWP_PIDLID) !=3D 0) {
 >    		lid =3D proc_alloc_pid(p2);
 >    		l2->l_pflag |=3D LP_PIDLID;
 >   +	} else if (p2->p_nlwps =3D=3D 0) {
 >   +		lid =3D l1->l_lid;
 >    	} else {
 >    		lid =3D 0;
 >    	}
 >
 >   --lrZ03NoBR/3+SXJZ--
 >
 >
 
 I am against this patch as it breaks the current implementation specific
 behavior where we pick lwp=3D1 for the first thread in a process.
 
 If there is anything depends on this lid logic, it's a bug in ld.elf_so.
 
 If there is need to detect forks and distinguish threads, it's possible
 to store the pid+lid pair.