Re: kern/54538 (wdc(4) regression after SATA NCQ merge)

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

The following reply was made to PR kern/54538; it has been noted by GNATS.

From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: jdolecek%NetBSD.org@localhost, tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: kern/54538 (wdc(4) regression after SATA NCQ merge)
Date: Tue, 10 Sep 2019 22:54:49 +0900

 > Committed a fix. Can you confirm it still works after change? The dreamcast
 > wdc reset didn't seem useful so I just disabled it.
 
 It looks wdc_g1_do_reset() is not necessary for wdcprobe(),
 but IIRC it was actually required on device accesses.
 
 GD-ROM is a very early ATAPI devices (appeared in 1998) and
 it doesn't reset its internal status by WDCTL_RST bit in AUXCTL
 but requires ATAPI_SOFT_RESET command, as per
 sys/arch/dreamcast/dev/gdrom.c.
 
 Anyway I'll try if your fix works or not.
 
 ---
 Izumi Tsutsui