[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: lib/54510 (libedit: filename completion broken in quote/double quaote)
The following reply was made to PR lib/54510; it has been noted by GNATS.
From: Rin Okuyama <rokuyama.rk%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost, abhinav%netbsd.org@localhost
Subject: Re: lib/54510 (libedit: filename completion broken in quote/double
Date: Mon, 9 Sep 2019 18:38:55 +0900
Thank you for working on this. The problems raised in the PR are fixed!
However, by looking into the code, I noticed some possible problems
related to unescape_string() function:
(1) Can we handle \\ (backslash escaped by backslash) correctly?
(2) In fn_complete(), unescacpe_string() is invoked via
find_word_to_complete(). After that, the cursor position and end of
buffer are substituted to *point and *end, respectively, that are
calculated based on the string before unescaped. Doesn't this break
3rd party softwares that provide completion_matches and/or
Main Index |
Thread Index |