NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: port-arm/54494: Olimex Teres laptop display is unresponsive after initial boot prompt



On Thu, Aug 29, Jared McNeill wrote:
> Please apply the following patch, run 'make dependall' in
> sys/stand/efiboot/bootaa64, then copy the resulting 'bootaa64.efi' to
> /boot/EFI/BOOT (replacing the current one).

Excellent this works!

ofctl -pl /chosen:
[Caching 164 nodes and 1327 properties]
00000164: /chosen

#address-cells          00000001 ........ ........ ........     1
#size-cells             00000001 ........ ........ ........     1
linux,stdout-path       2f736f63 40303163 30303030 302f7365   /soc@01c00000/se
            0010:       7269616c 40303163 32383030 303a3131   rial@01c28000:11
            0020:       35323030 00...... ........ ........   5200.
name                    63686f73 656e00.. ........ ........   "chosen"
netbsd,mbr              6fe50e65 b5ef3604 323ba4fe 0e1146a9   o..e..6.2;....F.
netbsd,partition        00000000 ........ ........ ........   ....
netbsd,uefi-memmap      00000007 00000000 40000000 00000000   ........@.......
            0010:       00007ef4 00000000 00000008 00000004   ..~.............
            0020:       00000000 47ef4000 00000000 00000018   ....G.@.........
            0030:       00000000 00000008 00000007 00000000   ................
            0040:       47f0c000 00000000 0006f31b 00000000   G...............
            0050:       00000008 00000002 00000000 b7227000   ............."p.
            0060:       00000000 000014c6 00000000 00000008   ................
            0070:       00000004 00000000 b86ed000 00000000   .........n......
            0080:       00000001 00000000 00000008 00000002   ................
            0090:       00000000 b86ee000 00000000 00000802   .....n..........
            00a0:       00000000 00000008 00000001 00000000   ................
            00b0:       b8ef0000 00000000 0000002f 00000000   .........../....
            00c0:       00000008 00000000 00000000 b8f1f000   ................
            00d0:       00000000 00000005 00000000 00000008   ................
            00e0:       00000004 00000000 b8f24000 00000000   ..........@.....
            00f0:       00000001 00000000 00000008 00000000   ................
            0100:       00000000 b8f25000 00000000 00000002   ......P.........
            0110:       00000000 00000008 00000006 00000000   ................
            0120:       b8f27000 00000000 00000001 80000000   ..p.............
            0130:       00000008 00000000 00000000 b8f28000   ................
            0140:       00000000 00000004 00000000 00000008   ................
            0150:       00000004 00000000 b8f2c000 00000000   ................
            0160:       00000002 00000000 00000008 00000000   ................
            0170:       00000000 b8f2e000 00000000 00000002   ................
            0180:       00000000 00000008 00000006 00000000   ................
            0190:       b8f30000 00000000 00000001 80000000   ................
            01a0:       00000008 00000000 00000000 b8f31000   ................
            01b0:       00000000 00000001 00000000 00000008   ................
            01c0:       00000002 00000000 b8f32000 00000000   .......... .....
            01d0:       0000501e 00000000 00000008 00000005   ..P.............
            01e0:       00000000 bdf50000 00000000 00000010   ................
            01f0:       80000000 00000008 00000002 00000000   ................
            0200:       bdf60000 00000000 000000a0 00000000   ................
            0210:       00000008 00000000 00000000 be000000   ................
            0220:       00000000 00000401 00000000 00000008   ................
            0230:       00000002 00000000 be401000 00000000   .........@......
            0240:       00001bff 00000000 00000008 ........   ............
netbsd,uefi-runtime-code
                        00000000 bdf50000 ffff8000 00002000   .............. .
            0010:       00000000 00010000 ........ ........   ........
netbsd,uefi-runtime-data
                        00000000 b8f27000 ffff8000 00000000   ......p.........
            0010:       00000000 00001000 00000000 b8f30000   ................
            0020:       ffff8000 00001000 00000000 00001000   ................
ranges
stdout-path             73657269 616c303a 31313532 30306e38   serial0:115200n8
            0010:       00...... ........ ........ ........   .

--------------------------------------------------------------------------------


000004d4: /chosen/framebuffer@be000000

allwinner,pipeline      6d697865 72302d6c 63643000 ........   mixer0-lcd0.
clocks                  00000002 00000064 00000003 00000006   .......d........
compatible              616c6c77 696e6e65 722c7369 6d706c65   "allwinner,simple
            0010:       2d667261 6d656275 66666572 00......   -framebuffer"
            001d:       73696d70 6c652d66 72616d65 62756666   "simple-framebuff
            002d:       657200.. ........ ........ ........   er"
eDP12-supply            00000005 ........ ........ ........   ....
eDP25-supply            00000004 ........ ........ ........   ....
format                  78387238 67386238 00...... ........   x8r8g8b8.
height                  00000300 ........ ........ ........   ....
linux,phandle           00000038 ........ ........ ........   ...8
name                    6672616d 65627566 66657200 ........   "framebuffer"
phandle                 00000038 ........ ........ ........   ...8
reg                     be000000 00400800 ........ ........   .....@..
status                  6f6b6179 00...... ........ ........   okay.
stride                  00001558 ........ ........ ........   ...X
width                   00000556 ........ ........ ........   ...V

--------------------------------------------------------------------------------


00000614: /chosen/framebuffer-hdmi

allwinner,pipeline      6d697865 72312d6c 6364312d 68646d69   mixer1-lcd1-hdmi
            0010:       00...... ........ ........ ........   .
clocks                  00000003 00000007 00000002 00000065   ...............e
            0010:       00000002 0000006e ........ ........   .......n
compatible              616c6c77 696e6e65 722c7369 6d706c65   "allwinner,simple
            0010:       2d667261 6d656275 66666572 00......   -framebuffer"
            001d:       73696d70 6c652d66 72616d65 62756666   "simple-framebuff
            002d:       657200.. ........ ........ ........   er"
linux,phandle           00000039 ........ ........ ........   ...9
name                    6672616d 65627566 6665722d 68646d69   "framebuffer-hdmi
            0010:       00...... ........ ........ ........   "
phandle                 00000039 ........ ........ ........   ...9
status                  64697361 626c6564 00...... ........   disabled.
vcc-hdmi-supply         00000006 ........ ........ ........   ....

--------------------------------------------------------------------------------


and dmesg:
[     1.000000] Copyright (c) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005,
[     1.000000] 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017,
[     1.000000] 2018, 2019 The NetBSD Foundation, Inc.  All rights reserved.
[     1.000000] Copyright (c) 1982, 1986, 1989, 1991, 1993
[     1.000000] The Regents of the University of California.  All rights reserved.

[     1.000000] NetBSD 9.0_BETA (GENERIC64) #0: Fri Aug 23 04:24:00 UTC 2019
[     1.000000]         mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/evbarm/compile/GENERIC64
[     1.000000] total memory = 2030 MB
[     1.000000] avail memory = 1957 MB
[     1.000000] timecounter: Timecounters tick every 10.000 msec
[     1.000000] armfdt0 (root)
[     1.000000] simplebus0 at armfdt0: Olimex A64 Teres-I
[     1.000000] simplebus1 at simplebus0
[     1.000000] cpus0 at simplebus0
[     1.000000] simplebus2 at simplebus0
[     1.000000] cpu0 at cpus0: Cortex-A53 r0p4 (Cortex V8-A core)
[     1.000000] cpu0: package 0, core 0, smt 0
[     1.000000] cpu0: IC enabled, DC enabled, EL0/EL1 stack Alignment check enabled
[     1.000000] cpu0: Cache Writeback Granule 16B, Exclusives Reservation Granule 16B
[     1.000000] cpu0: Dcache line 64, Icache line 64
[     1.000000] cpu0: L1 32KB/64B 2-way read-allocate VIPT Instruction cache
[     1.000000] cpu0: L1 32KB/64B 4-way write-back read-allocate write-allocate PIPT Data cache
[     1.000000] cpu0: L2 512KB/64B 16-way write-back read-allocate write-allocate PIPT Unified cache
[     1.000000] cpu0: revID=0x80, PMCv3, 4k table, 64k table, 16bit ASID
[     1.000000] cpu0: auxID=0x11120, FP, CRC32, SHA1, SHA256, AES+PMULL, NEON, rounding, NaN propagation, denormals, 32x64bitRegs, Fuse
d Multiply-Add
[     1.000000] cpu1 at cpus0: Cortex-A53 r0p4 (Cortex V8-A core)
[     1.000000] cpu1: package 0, core 1, smt 0
[     1.000000] cpu2 at cpus0: Cortex-A53 r0p4 (Cortex V8-A core)
[     1.000000] cpu2: package 0, core 2, smt 0
[     1.000000] cpu3 at cpus0: Cortex-A53 r0p4 (Cortex V8-A core)
[     1.000000] cpu3: package 0, core 3, smt 0
[     1.000000] gic0 at simplebus1: GIC
[     1.000000] armgic0 at gic0: Generic Interrupt Controller, 224 sources (215 valid)
[     1.000000] armgic0: 16 Priorities, 192 SPIs, 7 PPIs, 16 SGIs
[     1.000000] sunxisramc0 at simplebus1: SRAM Controller
[     1.000000] sunxisramc0: area: SRAM C
[     1.000000] fclock0 at simplebus0: 24000000 Hz fixed clock (osc24M)
[     1.000000] fclock1 at simplebus0: 32768 Hz fixed clock (ext-osc32k)
[     1.000000] gtmr0 at simplebus0: Generic Timer
[     1.000000] gtmr0: interrupting on GIC irq 27
[     1.000000] armgtmr0 at gtmr0: Generic Timer (24000 kHz, virtual)
[     1.000000] timecounter: Timecounter "armgtmr0" frequency 24000000 Hz quality 500
[     1.000010] sun50ia64ccu0 at simplebus1: A64 CCU
[     1.000010] sun50ia64rccu0 at simplebus1: A64 PRCM CCU
[     1.000010] sunxinmi0 at simplebus1: R_INTC
[     1.000010] sunxigpio0 at simplebus1: PIO
[     1.000010] gpio0 at sunxigpio0: 103 pins
[     1.000010] sunxigpio0: interrupting on GIC irq 43
[     1.000010] sunxigpio1 at simplebus1: PIO
[     1.000010] gpio1 at sunxigpio1: 13 pins
[     1.000010] sunxigpio1: interrupting on GIC irq 77
[     1.000010] sunxide2bus0 at simplebus1: DE2 Bus
[     1.000010] sunxirsb0 at simplebus1: RSB
[     1.000010] sunxirsb0: interrupting on GIC irq 71
[     1.000010] iic0 at sunxirsb0: I2C bus
[     1.000010] axppmic0 at iic0 addr 0x3a3: AXP803
[     1.000010] axpreg0 at axppmic0: vcc-hdmi
[     1.000010] axpreg1 at axppmic0: vcc-pd
[     1.000010] axpreg2 at axppmic0: vdd-edp
[     1.000010] axpreg3 at axppmic0: vcc-wifi-io
[     1.000010] axpreg4 at axppmic0: cpvdd
[     1.000010] axpreg5 at axppmic0: vcc-dvdd-csi
[     1.000010] axpreg6 at axppmic0: eldo3
[     1.000010] axpreg7 at axppmic0: vcc-1v2-hsic
[     1.000010] axpreg8 at axppmic0: vdd-cpus
[     1.000010] axpreg9 at axppmic0: vcc-3v3
[     1.000010] axpreg10 at axppmic0: vdd-cpux
[     1.000010] axpreg11 at axppmic0: dcdc3
[     1.000010] axpreg12 at axppmic0: dcdc4
[     1.000010] axpreg13 at axppmic0: vcc-ddr3
[     1.000010] axpreg14 at axppmic0: vdd-sys
[     1.000010] axpreg15 at axppmic0: vcc-pe
[     1.000010] axpreg16 at axppmic0: vcc-pl
[     1.000010] axpreg17 at axppmic0: vcc-pll-avcc
[     1.000010] fregulator0 at simplebus0: usb1-vbus
[     1.000010] sun6idma0 at simplebus1: DMA controller (8 channels)
[     1.000010] sun6idma0: interrupting on GIC irq 82
[     1.000010] sunxisid0 at simplebus1: Security ID EFUSE
[     1.000010] com0 at simplebus1: ns16550a, working fifo
[     1.000010] com0: console
[     1.000010] com0: interrupting on GIC irq 32
[     1.000010] sunxide2ccu0 at sunxide2bus0: DE2 CCU
[     1.000010] sunxiusbphy0 at simplebus1: USB PHY
[     1.000010] sunxihdmiphy0 at simplebus1: HDMI PHY
[     1.000010] sunximixer0 at sunxide2bus0: Display Engine Mixer
[     1.000010] sunximixer1 at sunxide2bus0: Display Engine Mixer
[     1.000010] /spdif-out at simplebus0 not configured
[     1.000010] sunxilcdc0 at simplebus1: TCON0
[     1.000010] sunxilcdc0 port 0 endpoint 0 connected to sunximixer0 port 1 endpoint 0
[     1.000010] sunxilcdc0: interrupting on GIC irq 118
[     1.000010] sunxilcdc1 at simplebus1: TCON1
[     1.000010] sunxilcdc1 port 0 endpoint 0 connected to sunximixer1 port 1 endpoint 0
[     1.000010] sunxilcdc1: interrupting on GIC irq 119
[     1.000010] mmcpwrseq0 at simplebus0: Simple MMC power sequence provider
[     1.000010] /soc/rtc@1f00000 at simplebus1 not configured
[     1.000010] genfb0 at simplebus2: Simple Framebuffer (1366x768 32-bpp @ 0xbe000000)
[     1.000010] genfb0: framebuffer at 0xbe000000, size 1366x768, depth 32, stride 5464
[     1.000010] wsdisplay0 at genfb0 kbdmux 1: console (default, vt100 emulation)
[     1.000010] wsmux1: connecting to wsdisplay0
[     1.000010] wsdisplay0: screen 1-3 added (default, vt100 emulation)
[     1.000010] sunximmc0 at simplebus1: SD/MMC controller
[     1.000010] sunximmc0: interrupting on GIC irq 92
[     1.000010] sunximmc1 at simplebus1: SD/MMC controller
[     1.000010] sunximmc1: interrupting on GIC irq 93
[     1.000010] sunximmc2 at simplebus1: SD/MMC controller
[     1.000010] sunximmc2: interrupting on GIC irq 94
[     1.000010] ehci0 at simplebus1: EHCI
[     1.000010] ehci0: interrupting on GIC irq 106
[     1.000010] ehci0: EHCI version 1.0
[     1.000010] ehci0: 1 companion controller, 1 port
[     1.000010] usb0 at ehci0: USB revision 2.0
[     1.000010] ohci0 at simplebus1: OHCI
[     1.000010] ohci0: interrupting on GIC irq 107
[     1.000010] ohci0: OHCI version 1.0
[     1.000010] usb1 at ohci0: USB revision 1.0
[     1.000010] sunxitwi0 at simplebus1: Marvell TWSI controller
[     1.000010] sunxitwi0: interrupting on GIC irq 38
[     1.000010] iic1 at sunxitwi0: I2C bus
[     1.000010] /soc/gpu@1c40000 at simplebus1 not configured
[     1.000010] sunxiwdt0 at simplebus1: Watchdog
[     1.000010] sunxiwdt0: default watchdog period is 16 seconds
[     1.000010] armpmu0 at simplebus0: Performance Monitor Unit
[     1.000010] psci0 at simplebus0: PSCI 1.1
[     1.000010] ausoc0 at simplebus0: On-board SPDIF
[     1.000010] gpiokeys0 at simplebus0: Lid Switch
[     1.000010] gpioleds0 at simplebus0: teres-i:green:capslock teres-i:green:numlock
[     1.000010] /soc/video-codec@1c0e000 at simplebus1 not configured
[     1.000010] ausoc0: autoconfiguration error: couldn't acquire cpu dai on sound_spdif node
[     1.000010] timecounter: Timecounter "clockinterrupt" frequency 100 Hz quality 0
[     1.000010] cpu2: IC enabled, DC enabled, EL0/EL1 stack Alignment check enabled
[     1.032646] cpu2: Cache Writeback Granule 16B, Exclusives Reservation Granule 16B
[     1.052648] cpu2: Dcache line 64, Icache line 64
[     1.062647] cpu2: L1 32KB/64B 2-way read-allocate VIPT Instruction cache
[     1.082648] cpu2: L1 32KB/64B 4-way write-back read-allocate write-allocate PIPT Data cache
[     1.112647] cpu2: L2 512KB/64B 16-way write-back read-allocate write-allocate PIPT Unified cache
[     1.142649] cpu2: revID=0x80, PMCv3, 4k table, 64k table, 16bit ASID
[     1.162649] cpu2: auxID=0x11120, FP, CRC32, SHA1, SHA256, AES+PMULL, NEON, rounding, NaN propagation, denormals, 32x64bitRegs, Fuse
d Multiply-Add
[     1.202650] cpu1: IC enabled, DC enabled, EL0/EL1 stack Alignment check enabled
[     1.222650] cpu1: Cache Writeback Granule 16B, Exclusives Reservation Granule 16B
[     1.242650] cpu1: Dcache line 64, Icache line 64
[     1.252650] cpu1: L1 32KB/64B 2-way read-allocate VIPT Instruction cache
[     1.282651] cpu1: L1 32KB/64B 4-way write-back read-allocate write-allocate PIPT Data cache
[     1.302652] cpu1: L2 512KB/64B 16-way write-back read-allocate write-allocate PIPT Unified cache
[     1.332652] cpu1: revID=0x80, PMCv3, 4k table, 64k table, 16bit ASID
[     1.352653] cpu1: auxID=0x11120, FP, CRC32, SHA1, SHA256, AES+PMULL, NEON, rounding, NaN propagation, denormals, 32x64bitRegs, Fuse
d Multiply-Add
[     1.392654] cpu3: IC enabled, DC enabled, EL0/EL1 stack Alignment check enabled
[     1.422655] cpu3: Cache Writeback Granule 16B, Exclusives Reservation Granule 16B
[     1.442656] cpu3: Dcache line 64, Icache line 64
[     1.452655] cpu3: L1 32KB/64B 2-way read-allocate VIPT Instruction cache
[     1.482656] cpu3: L1 32KB/64B 4-way write-back read-allocate write-allocate PIPT Data cache
[     1.502657] cpu3: L2 512KB/64B 16-way write-back read-allocate write-allocate PIPT Unified cache
[     1.532657] cpu3: revID=0x80, PMCv3, 4k table, 64k table, 16bit ASID
[     1.552657] cpu3: auxID=0x11120, FP, CRC32, SHA1, SHA256, AES+PMULL, NEON, rounding, NaN propagation, denormals, 32x64bitRegs, Fuse
d Multiply-Add
[     1.613287] sdmmc0 at sunximmc0
[     1.623308] sdmmc1 at sunximmc1
[     1.623308] sdmmc2 at sunximmc2
[     1.843292] uhub0 at usb0: NetBSD (0000) EHCI root hub (0000), class 9/0, rev 2.00/1.00, addr 1
[     1.853292] uhub0: 1 port with 1 removable, self powered
[     1.953294] uhub1 at usb1: NetBSD (0000) OHCI root hub (0000), class 9/0, rev 1.00/1.00, addr 1
[     1.963295] uhub1: 1 port with 1 removable, self powered
[     2.002763] sdmmc2: autoconfiguration error: switch error
[     2.002763] ld2 at sdmmc2: <0x13:0x014e:R1J56L:0x00:0x71a44760:0x000>
[     2.017308] sdmmc0: SD card status: 4-bit, C10, U1
[     2.022764] ld0 at sdmmc0: <0x41:0x3432:SDCIT:0x30:0x0029d0d0:0x121>
[     2.022764] (manufacturer 0x24c, product 0xb723, standard function interface code 0x7) at sdmmc1 function 1 not configured
[     2.143653] Lid Switch: lid opened.
[     2.143653] armpmu0: interrupting on GIC irq 184
[     2.153655] armpmu0: interrupting on GIC irq 185
[     2.163654] armpmu0: interrupting on GIC irq 186
[     2.163654] armpmu0: interrupting on GIC irq 187
[     2.173654] ld2: 14080 MB, 7151 cyl, 64 head, 63 sec, 512 bytes/sect x 28835840 sectors
[     2.183655] ld0: 7464 MB, 3791 cyl, 64 head, 63 sec, 512 bytes/sect x 15286272 sectors
[     2.193655] ld2: 8-bit width, 1024 KB cache, 52.000 MHz
[     2.203655] ld0: 4-bit width, High-Speed/SDR25, 50.000 MHz
[     2.223655] IPsec: Initialized Security Association Processing.
[     4.223693] uhub2 at uhub0 port 1: vendor 05e3 (0x5e3) USB2.0 Hub (0x608), class 9/0, rev 2.00/85.36, addr 2
[     4.233693] uhub2: single transaction translator
[     4.233693] uhub2: 4 ports with 4 removable, self powered
[     5.543719] urtwn0 at uhub2 port 1
[     5.543719] urtwn0: Realtek (0xbda) 802.11n NIC (0x8179), rev 2.00/0.00, addr 3
[     5.663722] urtwn0: MAC/BB RTL8188EU, RF 6052 1T1R, address 84:16:f9:1d:70:5c
[     5.673722] urtwn0: 1 rx pipe, 2 tx pipes
[     5.673722] urtwn0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps
[     5.683723] urtwn0: 11g rates: 1Mbps 2Mbps 5.5Mbps 11Mbps 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps
[     6.663742] uvideo0 at uhub2 port 3 configuration 1 interface 0: Generic (0x1908) USB2.0 PC CAMERA (0x2311), rev 2.00/1.00, addr 4
[     6.673742] video0 at uvideo0: Generic (0x1908) USB2.0 PC CAMERA (0x2311), rev 2.00/1.00, addr 4
[     7.663761] uhidev0 at uhub2 port 4 configuration 1 interface 0
[     7.663761] uhidev0: Olimex Ltd. (0x15ba) TERES Keyboard+Touchpad (0x3c), rev 1.10/0.01, addr 5, iclass 3/1
[     7.683762] ukbd0 at uhidev0: 8 Variable keys, 6 Array codes
[     8.093769] wskbd0 at ukbd0: console keyboard, using wsdisplay0
[     8.103770] uhidev1 at uhub2 port 4 configuration 1 interface 1
[     8.103770] uhidev1: Olimex Ltd. (0x15ba) TERES Keyboard+Touchpad (0x3c), rev 1.10/0.01, addr 5, iclass 3/1
[     8.123770] ums0 at uhidev1: 3 buttons and Z dir
[     8.133770] wsmouse0 at ums0 mux 0
[     8.133770] WARNING: 2 errors while detecting hardware; check system log.
[     8.153771] boot device: ld0
[     8.153771] root on ld0a dumps on ld0b
[     8.173771] root file system type: ffs
[     8.183772] kern.module.path=/stand/evbarm/9.0/modules
[     8.183772] WARNING: no TOD clock present
[     8.193772] WARNING: using filesystem time
[     8.197894] WARNING: CHECK AND RESET THE DATE!
[    32.144392] axppmic0: normal capacity on 'charge state'
[    33.064415] wsdisplay0: screen 4 added (default, vt100 emulation)

> Index: efifdt.c
> ===================================================================
> RCS file: /cvsroot/src/sys/stand/efiboot/efifdt.c,v
> retrieving revision 1.18
> diff -u -p -r1.18 efifdt.c
> --- efifdt.c	1 Aug 2019 13:11:16 -0000	1.18
> +++ efifdt.c	29 Aug 2019 10:05:22 -0000
> @@ -292,8 +292,15 @@ efi_fdt_gop(void)
>  			continue;
>  		}
> 
> +		fdt_setprop_u32(fdt_data,
> +		    fdt_path_offset(fdt_data, FDT_CHOSEN_NODE_PATH), "#address-cells", 2);
> +		fdt_setprop_u32(fdt_data,
> +		    fdt_path_offset(fdt_data, FDT_CHOSEN_NODE_PATH), "#size-cells", 2);
> +		fdt_setprop_empty(fdt_data,
> +		    fdt_path_offset(fdt_data, FDT_CHOSEN_NODE_PATH), "ranges");
> +
>  		snprintf(buf, sizeof(buf), "framebuffer@%" PRIx64, mode->FrameBufferBase);
> -		fb = fdt_add_subnode(fdt_data, fdt_path_offset(fdt_data, "/chosen"), buf);
> +		fb = fdt_add_subnode(fdt_data, fdt_path_offset(fdt_data, FDT_CHOSEN_NODE_PATH), buf);
>  		if (fb < 0)
>  			panic("FDT: Failed to create framebuffer node");
> 
> @@ -327,10 +334,6 @@ efi_fdt_bootargs(const char *bootargs)
>  	if (chosen < 0)
>  		panic("FDT: Failed to create " FDT_CHOSEN_NODE_PATH " node");
> 
> -	fdt_setprop_u32(fdt_data, chosen, "#address-cells", 2);
> -	fdt_setprop_u32(fdt_data, chosen, "#size-cells", 2);
> -	fdt_setprop_empty(fdt_data, chosen, "ranges");
> -
>  	if (*bootargs)
>  		fdt_setprop_string(fdt_data, chosen, "bootargs", bootargs);
> 
> 

Thanks!

-- 
ioh



Home | Main Index | Thread Index | Old Index