Re: PR/54343 CVS commit: src/usr.sbin/makemandb

[Abhinav Upadhyay <er.abhinav.upadhyay%gmail.com@localhost>]

On Sun, Aug 18, 2019 at 1:55 PM Thomas Klausner <wiz%netbsd.org@localhost> wrote:
>
> The following reply was made to PR bin/54343; it has been noted by GNATS.
>
> From: Thomas Klausner <wiz%NetBSD.org@localhost>
> To: gnats-bugs%netbsd.org@localhost
> Cc:
> Subject: Re: PR/54343 CVS commit: src/usr.sbin/makemandb
> Date: Sun, 18 Aug 2019 10:23:53 +0200
>
>  On Thu, Aug 15, 2019 at 10:30:02AM +0000, Christos Zoulas wrote:
>  >  Module Name:        src
>  >  Committed By:       christos
>  >  Date:               Thu Aug 15 10:29:07 UTC 2019
>  >
>  >  Modified Files:
>  >      src/usr.sbin/makemandb: apropos-utils.c
>  >
>  >  Log Message:
>  >  PR/54343: Prevent NULL pointers in callback strings; use "*?*" for now to
>  >  identify them.
>
>  After this commit, the output is:
>
>  ...
>  *?*/sd (4)        SCSI and ATAPI disk driver
>  ...to partition the disk into a BIOS level partition. This allows sharing the disk with other operating systems. The following config 1 options may be applied to SCSI disks as well as to other disks. SDRETRIES Set the number of...
>  ...
>
>  where I have the "*?*/" prefix for all matches (both with and without
>  "|less"). What should be there?

It was supposed to be the machine architecture for which the man page
was written, since not all man pages have it, the *?* prefix was being
output - I just fixed it.

>  But the core dump is gone.

Yes (thanks Christos). Looking at the core dump it seems that
makemandb failed to parse the section number of some man page and
therefore when reading it from the database it was NULL, thus the
crash. Without looking at the man page I am not really sure if it is a
bug in the man page or makemandb. With Christos' commit apropos will
not crash anymore and it should be easy to find which man page is
missing the section number. If you think that the man page is correct
and makemandb should have been able to parse the section, let me know.

Regards
Abhinav