NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: toolchain/54100: _HOST_ARCH on NetBSD/amd64 returns 'uname -m' not 'uname -p'

The following reply was made to PR toolchain/54100; it has been noted by GNATS.

From: Izumi Tsutsui <>
Subject: Re: toolchain/54100: _HOST_ARCH on NetBSD/amd64 returns 'uname -m'
	 not 'uname -p'
Date: Sun, 23 Jun 2019 15:18:47 +0900

 uwe@ pointed out on source-changed-d@:
 > The problem with the PR is the typo in the variable name, missing
 > leading underscore in
 > _HOST_ARCH:=	   ${HOST_ARCH:...}
 > note "HOST_ARCH" in the rhs, not "_HOST_ARCH".
 Actually the following change fix the problem
 (i.e. tooldir.NetBSD-8.1-x86_64 is created for tools):
 Index: share/mk/
 RCS file: /cvsroot/src/share/mk/,v
 retrieving revision 1.4
 diff -u -p -d -r1.4
 --- share/mk/	25 Feb 2018 18:53:23 -0000	1.4
 +++ share/mk/	23 Jun 2019 06:13:26 -0000
 @@ -49,7 +49,7 @@ _HOST_OSREL!=	uname -r
  # For _HOST_ARCH, if uname -p fails, or prints "unknown", or prints
  # something that does not look like an identifier, then use uname -m.
  _HOST_ARCH!=	uname -p 2>/dev/null
 -_HOST_ARCH:=	${HOST_ARCH:tW:C/.*[^-_A-Za-z0-9].*//:S/unknown//}
 +_HOST_ARCH:=	${_HOST_ARCH:tW:C/.*[^-_A-Za-z0-9].*//:S/unknown//}
  .if empty(_HOST_ARCH)
  _HOST_ARCH!=	uname -m
 Is it okay to commit the diff?
 Or should we keep bug compatibility for third party scripts?
 Izumi Tsutsui

Home | Main Index | Thread Index | Old Index