Re: bin/52737 (bmake crash for invalid usage of .PATH)

[Christos Zoulas <christos%zoulas.com@localhost>]

Yup, that should be great! Thanks!

christos

> On Apr 9, 2019, at 10:44 AM, Simon J. Gerraty <sjg%juniper.net@localhost> wrote:
> 
> Christos Zoulas <christos%zoulas.com@localhost> wrote:
> 
>> I'd rather unconditionally free "paths" if it was not NULL rather than add more complexity
>> to the code. This function needs to be split up; it is too big and complicated.
> 
> That works for me, so diff is then just:
> 
> diff -r 6f103b9234c3 bmake/parse.c
> --- a/bmake/parse.c	Sun Dec 30 09:28:02 2018 -0800
> +++ b/bmake/parse.c	Tue Apr 09 10:42:04 2019 -0700
> @@ -1768,7 +1768,8 @@
>     }
> 
> out:
> -    assert(paths == NULL);
> +    if (paths)
> +	Lst_Destroy(paths, NULL);
>     if (curTargs)
> 	    Lst_Destroy(curTargs, NULL);
> }
> 
> 
> -- 
> This message has been 'sanitized'.  This means that potentially
> dangerous content has been rewritten or removed.  The following
> log describes which actions were taken.
> 
> Sanitizer (start="1554831880"):
>  Split unusually long word(s) in header.
>  SanitizeFile (filename="unnamed.txt, 68181.1554831865.1%kaos.jnpr.net@localhost", mimetype="text/plain"):
>    Match (names="unnamed.txt", rule="9"):
>      Enforced policy: accept
> 
>  Total modifications so far: 1
> 
> 
> Anomy 0.0.0 : Sanitizer.pm
> $Id: Sanitizer.pm,v 1.94 2006/01/02 16:43:10 bre Exp $