NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

kern/53849: Fix comment lfs.h Offset of di_spare is wrong



>Number:         53849
>Category:       kern
>Synopsis:       Fix comment lfs.h Offset of di_spare is wrong
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 10 00:45:00 +0000 2019
>Originator:     José Luis Rodríguez García
>Release:        current
>Organization:
>Environment:
>Description:
The di_spare[1] member of the structure lfs64_dinode begins at offset 248 instead of 244.

The di_inumber was changed from 32 to 64 bits in the 1.179 version of lfs.h, but the comment wasn't updated.
>How-To-Repeat:

>Fix:
$ cvs diff -u -N
cvs diff: Diffing .
Index: lfs.h
===================================================================
RCS file: /cvsroot/src/sys/ufs/lfs/lfs.h,v
retrieving revision 1.203
diff -u -r1.203 lfs.h
--- lfs.h	26 Jul 2017 16:42:37 -0000	1.203
+++ lfs.h	10 Jan 2019 00:10:58 -0000
@@ -467,7 +467,7 @@
 	int64_t		di_ib[ULFS_NIADDR]; /* 208: Indirect disk blocks. */
 	uint64_t	di_modrev;	/* 232: i_modrev for NFSv4 */
 	uint64_t	di_inumber;	/* 240: Inode number */
-	uint64_t	di_spare[1];	/* 244: Reserved; currently unused */
+	uint64_t	di_spare[1];	/* 248: Reserved; currently unused */
 };
 
 union lfs_dinode {



Home | Main Index | Thread Index | Old Index