[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: port-macppc/53727: boot floppy doesn't work for openfirmware version 1 machines?
The following reply was made to PR port-macppc/53727; it has been noted by GNATS.
From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
Cc: gnats-bugs%NetBSD.org@localhost, tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: port-macppc/53727: boot floppy doesn't work for openfirmware version
Date: Thu, 15 Nov 2018 00:36:52 +0900
> patch is needed for both OFW1 and OFW2 machines? So how about something
> - if (map->sbSig == DRIVER_MAP_MAGIC)
> + /* OF1 & OF2 won't boot floppy with faked APM */
> + if (ofw_version < 3 && strncmp(devname,"fd",2) == 0)
> + error = search_dos_label(&ofdev, 0, buf,
> + &label, 0);
> + else if (map->sbSig == DRIVER_MAP_MAGIC)
There are two thoughts:
- To check floppy devices, we already have is_floppyboot() in boot.c
(it can also handle the "real" device names like swim3 etc.)
- I don't think checking dos label (i.e. FDISK/MBR partition table)
against a floppy makes sense here.
(most floppies don't have MBR so it just returns ERDLAB in the MAGIC
check in search_dos_label())
Maybe we should rather check ustarfs, or just skip label checks
Main Index |
Thread Index |