NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/53280: amd64 panics since recent compat/netbsd32 commits



The following reply was made to PR kern/53280; it has been noted by GNATS.

From: Andreas Gustafsson <gson%gson.org@localhost>
To: christos%zoulas.com@localhost (Christos Zoulas), gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/53280: amd64 panics since recent compat/netbsd32 commits
Date: Sat, 12 May 2018 23:08:21 +0300

 Christos Zoulas wrote:
 > I can't possibly "hear" you, but I've "read" you. You are running
 > the tests and while your work is appreciated, without being able
 > to reproduce your environment, I can't fix the issue.
 
 Reverting your commit will fix the panic.  Then you can fix the issue
 without everyone having to suffer from the panic while you do it.
 
 > I am simply asking how it is possible to execute compat-netbsd32
 > code from a 64 bit binary!
 
 I have no idea, and I don't think finding out should be my
 responsibility.
 
 > I added the code because nsd needs send and recv mmsg which were
 > missing. So removing the code breaks nsd which is not a test...
 
 Fixing nsd does not justify making the system panic.
 
 > In addition, I have more
 > tests that I have not committed because the code is broken in
 > different ways (the code before I committed my stuff). I can revert
 > the new changes and commit the new tests and then you can have
 > different broken tests :-) This is what tests are all about anyway:
 > to detect broken code...
 
 Yes, that is how it should work.  A few broken tests is vastly better
 than having no test results at all because the system paniced before
 the test run completed.
 -- 
 Andreas Gustafsson, gson%gson.org@localhost
 


Home | Main Index | Thread Index | Old Index