Re: kern/53066: nearly reproducable softint panic on shutdown

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR kern/53066; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/53066: nearly reproducable softint panic on shutdown
Date: Sat, 21 Apr 2018 14:56:01 +0200

 This patch seems to fix it for me. It looks like a good enough compromise
 from a layering point of view.
 
 Maybe xhci should mask interrupts earlier (or the intr handler should not
 return 1 in this case), but that is something for someone with better
 hardware knowledge to decide.
 
 Martin
 
 
 Index: usb.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/usb/usb.c,v
 retrieving revision 1.168
 diff -u -p -r1.168 usb.c
 --- usb.c	28 Oct 2017 00:37:12 -0000	1.168
 +++ usb.c	21 Apr 2018 12:27:31 -0000
 @@ -1081,7 +1081,7 @@ usb_schedsoftintr(struct usbd_bus *bus)
  
  	if (bus->ub_usepolling) {
  		bus->ub_methods->ubm_softint(bus);
 -	} else {
 +	} else if (bus->ub_soft != NULL) { /* bus may have been detached */
  		kpreempt_disable();
  		softint_schedule(bus->ub_soft);
  		kpreempt_enable();