Re: kern/52888: Add autofs for NetBSD

[Tomohiro Kusumi <kusumi.tomohiro%gmail.com@localhost>]

The following reply was made to PR kern/52888; it has been noted by GNATS.

From: Tomohiro Kusumi <kusumi.tomohiro%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/52888: Add autofs for NetBSD
Date: Sun, 7 Jan 2018 14:40:01 +0200

 Hi
 Thanks for the comments.
 I've uploaded -v2 patch which applies to 8.99.11 as of 2018.1.5.
 
 diff -aNur
 https://leaf.dragonflybsd.org/~tkusumi/diff/netbsd/NetBSD-autofs-v2.patch
 git format-patch
 https://leaf.dragonflybsd.org/~tkusumi/diff/netbsd/0001-NetBSD-autofs-v2.pa=
 tch
 
 Changes are as follows.
 1. Add ZFS support to fstyp(8) which gets compiled if ${MKZFS} !=3D
 "no". The reason for checking ${MKZFS} is because it requires ZFS
 libraries rather than just headers defining ondisk format (that are
 visible via -I${NETBSDSRCDIR}/external/cddl/... regardless of
 ${MKZFS}). This mechanism is pretty much the same with FreeBSD
 fstyp(8).
 2. Change the first-appeared-version in newly added man pages to 9.0.
 3. Change autofs_enable=3D to autofs=3D.
 4. Bring in recent updates from FreeBSD for etc/autofs/* scripts.
 
 I'll dogfood it for another few weeks, and then drop -v3 patch if any updat=
 e.
 Meanwhile any comments are appreciated.
 
 
 2018-01-03 11:45 GMT+02:00 Thomas Klausner <wiz%netbsd.org@localhost>:
 > The following reply was made to PR kern/52888; it has been noted by GNATS=
 .
 >
 > From: Thomas Klausner <wiz%NetBSD.org@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc:
 > Subject: Re: kern/52888: Add autofs for NetBSD
 > Date: Wed, 3 Jan 2018 10:41:35 +0100
 >
 >  On Tue, Jan 02, 2018 at 07:15:00PM +0000, kusumi.tomohiro%gmail.com@localhost wrot=
 e:
 >  > >Number:         52888
 >  > >Category:       kern
 >  > >Synopsis:       Add autofs for NetBSD
 >
 >  Thank you very much! That must have been a big piece of work.
 >
 >  Some minor comments:
 >
 >  > 4. usr.sbin/fstyp - Filesystem type detection utility
 >  > Fstyp(8) is an utility to detect filesystem type of the given block de=
 vice, and it was originally added to FreeBSD for autofs. It's been used by =
 automountd(8) to detect filesystem type of block devices to auto mount when=
  "-media" map is specified in auto_master(5). See auto_master(5) for detail=
 s of "-media" map. Fstyp(8) supports filesystems such as UFS, ext2, ISO9660=
 , FAT, NTFS. FreeBSD version also supports ZFS, and DragonFlyBSD version su=
 pports HAMMER, but these two are dropped in NetBSD. Note that auto mounting=
  NFS doesn't require fstyp(8) or "-media" map.
 >
 >  NetBSD supports ZFS, so recognizing that would be useful.
 >
 >  > 4. "xxx first appeared in NetBSD <version>" in newly added man pages h=
 ave "8.99.1" for <version> at the moment. There are several new man pages, =
 such as autofs(5), auto_master(5), automount(8), automountd(8), autounmount=
 d(8), fstyp(8). These man pages are all from FreeBSD as well.
 >
 >  We usually do not mention -current release numbers in man pages this
 >  way, so this should be "9.0" instead of "8.99.1".
 >
 >  Cheers,
 >   Thomas
 >