Re: kern/52820: "boot -1" panics on systems with ixgX interfaces

[Frank Kardel <kardel%netbsd.org@localhost>]

The following reply was made to PR kern/52820; it has been noted by GNATS.

From: Frank Kardel <kardel%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost, kern-bug-people%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/52820: "boot -1" panics on systems with ixgX interfaces
Date: Thu, 21 Dec 2017 12:05:53 +0100

 Hi!
 
 Seems working now - no panic while initializing interfaces at "boot -1" 
 for my board :-), but a another panic later on
 
 with todays -current with regard to IFNET locking :-( (posted to 
 tech-{kern,net}).
 
 Looks like this bug is fixed.
 
 Thanks & Best regards,
 
    Frank
 
 
 On 12/21/17 10:30, Masanobu SAITOH wrote:
 > The following reply was made to PR kern/52820; it has been noted by GNATS.
 >
 > From: Masanobu SAITOH <msaitoh%execsw.org@localhost>
 > To: gnats-bugs%NetBSD.org@localhost, kern-bug-people%netbsd.org@localhost,
 >   gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, kardel%netbsd.org@localhost
 > Cc: msaitoh%execsw.org@localhost
 > Subject: Re: kern/52820: "boot -1" panics on systems with ixgX interfaces
 > Date: Thu, 21 Dec 2017 18:26:16 +0900
 >
 >   On 2017/12/21 15:50, Frank Kardel wrote:
 >   > The following reply was made to PR kern/52820; it has been noted by GNATS.
 >   >
 >   > From: Frank Kardel <kardel%netbsd.org@localhost>
 >   > To: gnats-bugs%NetBSD.org@localhost
 >   > Cc:
 >   > Subject: Re: kern/52820: "boot -1" panics on systems with ixgX interfaces
 >   > Date: Thu, 21 Dec 2017 07:46:52 +0100
 >   >
 >   >   Sure -  awaiting your fix.
 >   
 >     Try ixgbe.c rev. 1.117
 >   
 >     Note that this driver don't support INTx on X550_X and X550_A.
 >   
 >   
 >     - msaitoh
 >   
 >   
 >   >
 >   >   On 12/21/17 05:55, Masanobu SAITOH wrote:
 >   >   > On 2017/12/20 17:55, Masanobu SAITOH wrote:
 >   >   >> The following reply was made to PR kern/52820; it has been noted by
 >   >   >> GNATS.
 >   >   >>
 >   >   >> From: Masanobu SAITOH <msaitoh%execsw.org@localhost>
 >   >   >> To: gnats-bugs%NetBSD.org@localhost, kern-bug-people%netbsd.org@localhost,
 >   >   >>   gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, kardel%netbsd.org@localhost
 >   >   >> Cc: msaitoh%execsw.org@localhost
 >   >   >> Subject: Re: kern/52820: "boot -1" panics on systems with ixgX
 >   >   >> interfaces
 >   >   >> Date: Wed, 20 Dec 2017 17:54:08 +0900
 >   >   >>
 >   >   >>   On 2017/12/15 18:40, Frank Kardel wrote:
 >   >   >>   > The following reply was made to PR kern/52820; it has been noted
 >   >   >> by GNATS.
 >   >   >>   >
 >   >   >>   > From: Frank Kardel <kardel%netbsd.org@localhost>
 >   >   >>   > To: gnats-bugs%NetBSD.org@localhost
 >   >   >>   > Cc:
 >   >   >>   > Subject: Re: kern/52820: "boot -1" panics on systems with ixgX
 >   >   >> interfaces
 >   >   >>   > Date: Fri, 15 Dec 2017 10:37:28 +0100
 >   >   >>   >
 >   >   >>   >   You are correct - my mistake - nevertheless the bug is valid.
 >   >   >> I'll fix
 >   >   >>   >   that the bug.
 >   >   >>       I've fixed this panic now. Please try ixgbe.c rev. 1.116.
 >   >   >
 >   >   >  Additional fix is required for some error condition. Please wait a
 >   >   > little.
 >   >   >
 >   >   >
 >   >   >
 >   >   >
 >   >   >>   > Log Message:
 >   >   >>   >  Don't panic when resource shortage occured. Fixes PR#52820
 >   >   >> reported by
 >   >   >>   > kardel@:
 >   >   >>   >  - Don't use if_free() because ixgbe(4) don't use if_alloc().
 >   >   >>   >  - Move location of {ixgbe,ixv}_setup_interface() call at a
 >   >   >> position that
 >   >   >>   >    any error don't occur. One of the reason is that it should be.
 >   >   >> Another
 >   >   >>   >    reason is that it's hard to call ether_ifdetach() and
 >   >   >> if_detach() when
 >   >   >>   >    cold == 1 (because of pserialize_perform, xc_wait, timing of
 >   >   >> domaininit
 >   >   >>   >    and maybe more).
 >   >   >>   >
 >   >   >>   >
 >   >   >>   > To generate a diff of this commit:
 >   >   >>   > cvs rdiff -u -r1.115 -r1.116 src/sys/dev/pci/ixgbe/ixgbe.c
 >   >   >>         - msaitoh
 >   >   >>         >
 >   >   >>   >   On 12/15/17 09:00, Manuel Bouyer wrote:
 >   >   >>   >   > The following reply was made to PR kern/52820; it has been
 >   >   >> noted by GNATS.
 >   >   >>   >   >
 >   >   >>   >   > From: Manuel Bouyer <bouyer%antioche.eu.org@localhost>
 >   >   >>   >   > To: gnats-bugs%NetBSD.org@localhost
 >   >   >>   >   > Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
 >   >   >> netbsd-bugs%netbsd.org@localhost
 >   >   >>   >   > Subject: Re: kern/52820: "boot -1" panics on systems with
 >   >   >> ixgX interfaces
 >   >   >>   >   > Date: Fri, 15 Dec 2017 08:59:40 +0100
 >   >   >>   >   >
 >   >   >>   >   >   On Fri, Dec 15, 2017 at 12:40:00AM +0000, kardel%netbsd.org@localhost
 >   >   >> wrote:
 >   >   >>   >   >   > >How-To-Repeat:
 >   >   >>   >   >   >     try "boot -1" on aformentioned machine.
 >   >   >>   >   >   > >Fix:
 >   >   >>   >   >   >     Avoid booting single user...
 >   >   >>   >   >
 >   >   >>   >   >   -1 is not single-user, it's monoprocessor
 >   >   >>   >   >   -s is single user.
 >   >   >>   >   >
 >   >   >>   >   >   --
 >   >   >>   >   >   Manuel Bouyer <bouyer%antioche.eu.org@localhost>
 >   >   >>   >   >        NetBSD: 26 ans d'experience feront toujours la difference
 >   >   >>   >   >   --
 >   >   >>   >   >
 >   >   >>   >
 >   >   >>   >
 >   >   >>       --
 >   >   >>   -----------------------------------------------
 >   >   >>                    SAITOH Masanobu (msaitoh%execsw.org@localhost
 >   >   >>                                     msaitoh%netbsd.org@localhost)
 >   >   >>
 >   >   >
 >   >   >
 >   >
 >   >
 >   
 >   
 >   --
 >   -----------------------------------------------
 >                    SAITOH Masanobu (msaitoh%execsw.org@localhost
 >                                     msaitoh%netbsd.org@localhost)
 >