NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

kern/52812: src/tests/kernel/t_timeleft.c doesn't compile with MKRUMP=no



>Number:         52812
>Category:       kern
>Synopsis:       src/tests/kernel/t_timeleft.c doesn't compile with MKRUMP=no
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 12 17:40:00 +0000 2017
>Originator:     scole_mail
>Release:        current
>Organization:
none
>Environment:
NetBSD dstar 7.1.0_PATCH NetBSD 7.1.0_PATCH (GENERIC) #1: Wed Nov 29 14:17:46 PST 2017  scole@dstar:/home/scole/nbsd/cvs/7_0/obj/sys/arch/i386/compile/GENERIC i386
>Description:
ia64 can't build rump and currently has MKRUMP=no.  If a distribution or release is attempted to be built it fails with:

t_timeleft.o: In function `tester':
/usr/src/tests/kernel/t_timeleft.c:92: undefined reference to `pthread_create'
/usr/src/tests/kernel/t_timeleft.c:95: undefined reference to `pthread_kill'
collect2: error: ld returned 1 exit status

The attached patch worked for me, but someone who understand the test framework better should look at this.

Thanks

>How-To-Repeat:
build a distribution or release with MKRUMP=no
>Fix:
Apply patch with "cd .../src/tests/kernel ; patch -s -p0 < .../patchfile"

Index: Makefile
===================================================================
RCS file: /cvsroot/src/tests/kernel/Makefile,v
retrieving revision 1.50
diff -b -u -r1.50 Makefile
--- Makefile	10 Dec 2017 15:37:54 -0000	1.50
+++ Makefile	12 Dec 2017 17:23:04 -0000
@@ -46,9 +46,8 @@
 LDADD.t_filedesc+=  ${LDADD.t_rnd}
 LDADD.t_rnd+=  -lrumpvfs -lrumpdev_rnd -lrumpdev -lrump -lrumpuser
 LDADD.t_rnd+=  -lrump -lpthread
-LDADD.t_timeleft+=	-lpthread
-
 .endif
+LDADD.t_timeleft+=	-lpthread
 
 CPPFLAGS+=	-D_KERNTYPES



Home | Main Index | Thread Index | Old Index