NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/52074: -current npf map directive broken



On 10/12/2017 00:31, Mindaugas Rasiukevicius wrote:
Frank Kardel <kardel%netbsd.org@localhost> wrote:
Hi Roy !

Would be possible, but I think we are not gaining any benefit from the
additional look-up.
Before the packet filter we see the originating interface. That is the
one for which we need to count the bytes sent.
After the packet filter we see either no change most of the time, some
other local interface or nothing.
So I would prefer just to look the the originating interface.

There is one subtle case for not being able to find the correct local
interface from the source address.
In BSD multiple interfaces can have the same IP address. In this
situation we cannot correctly determine
the correct interface from the source address alone for bytes-sent
accounting.
As this didn't work properly up to now we are not making things worse
with respect to bytes-sent accounting.


AFAIK this fixed in -current, right?


Christos fixed if in sys/netinet/ip_output -r1.277

Roy


Home | Main Index | Thread Index | Old Index