NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: port-pmax/52683: src/sys/arch/pmax/ibus/sii.c:342: 2 * redundant assignment



The following reply was made to PR port-pmax/52683; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: port-pmax/52683: src/sys/arch/pmax/ibus/sii.c:342: 2 * redundant assignment 
Date: Tue, 31 Oct 2017 20:39:37 +0700

     Date:        Tue, 31 Oct 2017 11:55:00 +0000 (UTC)
     From:        dcb314%hotmail.com@localhost
     Message-ID:  <20171031115500.B63C57A214%mollari.NetBSD.org@localhost>
 
   | src/sys/arch/pmax/ibus/sii.c:342]: (warning) Redundant assignment of 'regs->cstat' to itself.
   | > [src/sys/arch/pmax/ibus/sii.c:343]: (warning) Redundant assignment of 'regs->dstat' to itself.
   | 
   | 
   | Source code is
   | 
   |     regs->cstat = regs->cstat;
   |     regs->dstat = regs->dstat;
 
 Again, these are hardware registers (in a struct declared volatile) and
 assigning this way is an entirely reasonable thing to do.
 
 If you are going to report "errors" like this, please check first that
 they are not just false positives from whatever tool it is that you are
 using.
 
 kre
 


Home | Main Index | Thread Index | Old Index