install/52514: squid breaks on FreeBSD due to IPF enabled option

[angelmadames%gmail.com@localhost]

>Number:         52514
>Category:       install
>Synopsis:       squid breaks on FreeBSD due to IPF enabled option
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    install-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 30 14:30:00 +0000 2017
>Originator:     Angel Adames
>Release:        2017Q2
>Organization:
FutureLink Corporation
>Environment:
FreeBSD flc1 11.0-RELEASE-p12 FreeBSD 11.0-RELEASE-p12 #0: Wed Aug  9 10:03:39 UTC 2017     root%amd64-builder.daemonology.net@localhost:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
The package www/squid3 breaks on FreeBSD due to --enable-ipf-transparent being enabled by default through the options.mk framework. The legacy option to enable/disable this is squid.ipf. Nevertheless, it shouldn't be enabled by default since it has been reportedly breaking some system builds (including linux and some BSD systems).
>How-To-Repeat:
Simply run bmake configure in squid package directory on a FreeBSD machine. This will trough the following output in the configure phase:

> configure: error: unable to make IPFilter work with netinet/ headers.

Also, by looking at config.log more details could be gathered. 
>Fix:
Using the options framework, adding this to mk.conf:

PKG_OPTIONS.squid+=    -squid-ipf

OR applying this patch so squid-ipf is not enabled by default on FreeBSD systems:


$NetBSD$

--- options.mk.orig	2017-05-03 08:38:45.000000000 +0000
+++ options.mk
@@ -33,12 +33,12 @@ PKG_SUPPORTED_OPTIONS+=	squid-netfilter
 PKG_SUPPORTED_OPTIONS+=	squid-ipf
 .endif
 
-.if ${OPSYS} == "FreeBSD" || ${OPSYS} == "NetBSD" || ${OPSYS} == "OpenBSD" || \
+.if ${OPSYS} == "NetBSD" || ${OPSYS} == "OpenBSD" || \
     ${OPSYS} == "Darwin" || ${OPSYS} == "DragonFly"
 PKG_SUPPORTED_OPTIONS+=	squid-pf
 .endif
 
-.if (${OPSYS} == "FreeBSD" || ${OPSYS} == "NetBSD") && \
+.if ${OPSYS} == "NetBSD" && \
 	!empty(PKG_SUPPORTED_OPTIONS:Msquid-ipf)
 PKG_SUGGESTED_OPTIONS+=	squid-ipf
 .endif