Re: toolchain/52482: Broken makefile include order?

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR toolchain/52482; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: toolchain/52482: Broken makefile include order?
Date: Sun, 13 Aug 2017 11:45:23 +0200

 On Sat, Aug 12, 2017 at 07:20:01PM +0000, Joerg Sonnenberger wrote:
 >  Please the bsd.init.mk with bsd.own.mk?
 
 Tricky:
 
 we need to get 
 
 NOSSP=          # defined
 NOPIE=          # defined
 NOMAN=          # defined
 
 from ../Makefile.inc, then .include bsd.own.mk, and then ammend
 CPPFLAGS and CFLAGS in ../Makefile.inc again.
 
 I guess this is the easiest hack:
 
 Index: Makefile.inc
 ===================================================================
 RCS file: /cvsroot/src/sys/arch/sparc/stand/Makefile.inc,v
 retrieving revision 1.14
 diff -u -r1.14 Makefile.inc
 --- Makefile.inc	1 Oct 2016 13:57:44 -0000	1.14
 +++ Makefile.inc	13 Aug 2017 09:43:28 -0000
 @@ -7,6 +7,8 @@
  BINDIR=		/usr/mdec
  NOPIE=		yes
  
 +.include <bsd.own.mk>
 +
  CPPFLAGS+=	-DSTANDALONE -I.
  CFLAGS+=	-ffreestanding ${${ACTIVE_CC} == "gcc":? -msoft-float :}
  
 
 This relies on bsd.own.mk protecting itself against multiple inclusion,
 but it does and will always do - so is this the right fix?
 
 Martin