Re: lib/44073 (libnetpgp: only export the netpgp_* symbols)

[Pierre Pronchery <khorben%defora.org@localhost>]

			Hi everyone,

On 02/10/2016 20:57, dholland%NetBSD.org@localhost wrote:
> Synopsis: libnetpgp: only export the netpgp_* symbols
>
> Responsible-Changed-From-To: lib-bug-people->agc
> Responsible-Changed-By: dholland%NetBSD.org@localhost
> Responsible-Changed-When: Sun, 02 Oct 2016 18:57:52 +0000
> Responsible-Changed-Why:
> over to author, who obviously never saw this

I believe the patch submitted has no real effect, because:
- it patches "Makefile.in" in dist/ and not the actual Makefile
  there;
- the library is really built from lib/netpgp/Makefile anyway.

This can be confirmed with nbmake with MAKEVERBOSE=2, as follows:

> #     build  netpgp/libnetpgp.so.3.0
> rm -f libnetpgp.so.3.0
> /usr/src/obj-amd64/tooldir.NetBSD-7.1_RC1-amd64/bin/x86_64--netbsd-gcc  -Wl,-x -shared -Wl,-soname,libnetpgp.so.3 -Wl,--warn-shared-textrel -Wl,-Map=libnetpgp.so.3.map   --sysroot=/usr/src/obj-amd64/destdir.amd64  -o libnetpgp.so.3.0  -Wl,-rpath-link,/usr/src/obj-amd64/destdir.amd64/lib  -L=/lib  -Wl,--whole-archive libnetpgp_pic.a  -Wl,--no-whole-archive -L/usr/src/obj-amd64/crypto/external/bsd/netpgp/libmj -lmj -L/usr/src/obj-amd64/crypto/external/bsd/openssl/lib/libcrypto -lcrypto -L/usr/src/obj-amd64/lib/libz -lz -L/usr/src/obj-amd64/lib/libbz2 -lbz2

So libtool is not involved at all here...

Can this be implemented another way?
The same issue also applies to libnetpgpverify.so by the way.

HTH,
--
khorben